Handle Bundler::HTTPErrors during bundle install
#3699
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How to use the Graphite Merge QueueAdd the label graphite-merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
egiurleo
added
other
Graphite App
vinistock
approved these changes
Jul 31, 2025
It turns out, `Bundler::Fetcher::NetworkDownError` is actually a subclass of `Bundler::HTTPError`, and both have shown up in our telemetry. By rescuing only `Bundler::HTTPError`, we also rescue all subclasses that might indicate other bundler networking errors as well.
egiurleo
changed the base branch from
ignore-operation-not-permitted
to
graphite-base/3699
egiurleo
force-pushed
the
ignore-http-error
branch
from
8f2b64d to
474a760
Compare
egiurleo
force-pushed
the
graphite-base/3699
branch
from
d638388 to
9a027cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In addition to
Bundler::Fetcher::NetworkDownErrors, a Bundler networking issue might be indicated by a variety ofBundler::HTTPErrors. By rescuing the parent error class, we can protect against any of these child errors from cluttering our telemetry.Implementation
I switched out the rescue for
Bundler::Fetcher::NetworkDownErrorforBundler::HTTPError.Automated Tests
I kept the original test and added a separate
Bundler::HTTPErrortest, ensuring that this would catch both the parent error class and any of its children.