Switch shared_ptr<T> for polymorphic<T> for several classes
#159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great work @edantec. On my end I think I can fix the Python bindings soon enough. |
edantec
force-pushed
the
topic/edantec_polymorphic
branch
3 times, most recently
from
fc1030c to
e35e545
Compare
ManifoldFR
force-pushed
the
topic/edantec_polymorphic
branch
3 times, most recently
from
a764879 to
6fb8862
Compare
ManifoldFR
force-pushed
the
topic/edantec_polymorphic
branch
from
6fb8862 to
f513de5
Compare
ManifoldFR
force-pushed
the
topic/edantec_polymorphic
branch
2 times, most recently
from
f105adc to
69c5ed2
Compare
edantec
force-pushed
the
topic/edantec_polymorphic
branch
from
68afaff to
5353373
Compare
ManifoldFR
changed the title
shared_ptr<T> for polymorphic<T>
ManifoldFR
changed the title
shared_ptr<T> for polymorphic<T>shared_ptr<T> for polymorphic<T> for several classes
edantec
force-pushed
the
topic/edantec_polymorphic
branch
from
64788f0 to
f5c41a2
Compare
added 12 commits
July 9, 2024 15:19
…e main hpp header + also declare costDirectionalDerivative in .txx file
same for traj-opt-problem + include tracy and mpc-util.hpp header when necessary
+ add hxx impl header for stage-data.hpp + optimize includes for traj-opt-data.hpp (do not include hxx file) + function-abstract.hpp : remove include of clone.hpp header + do not include hxx impl file for ExplicitDynamics + move include of function-abstract.hxx file to cpp file only
ManifoldFR
force-pushed
the
topic/edantec_polymorphic
branch
from
5869340 to
01606fa
Compare
proxsuite-nlp>=0.8.0
ManifoldFR
force-pushed
the
topic/edantec_polymorphic
branch
from
38b3d33 to
d009aca
Compare
+ evaluate() and computeJacobians() no longer pure virtual
… pure virtual + allows for default ctor
|
CI is cooked, let's just merge this and fix it later |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A PR to discuss how we integrate polymorphism with value semantics (instead of smart pointers) into Aligator.
This PR is a follow-up to Simple-Robotics/proxsuite-nlp/pull/90 which does this for manifold types.