ENH: Add detached vtkIECTransformLogic library to SlicerRT superbuild #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit was authored by TrosnyogoSzakoca. I just rebased it to current tip of master branch. -Change existing code to use new library instead of vtkSlicerIECTransformLogic -Delete old vtkSlicerIECTransformLogic -Add new external cmake to superbuild folder -Update CMakeLists -Main problem: dll not found errors during SlicerRT startup
|
First thing first. |
It's already the case: https://github.com/EBATINCA/RadiotherapyTransformsIEC (This merge request pulls the repo from there as a Superbuild, as you rightly suggest) |
lassoan
reviewed
Oct 10, 2024
ferdymercury
commented
Oct 10, 2024
|
I've tried to compile without SuperBuild and got some errors: CMake output: Compilation output: Basically SlicerRT can't find non-existent include directory. |
|
Thanks a lot for checking. I've just fixed the error in the include path. Could you git-pull the IEC repo and retry? |
|
SuperBuild under Linux compiles and runs without errors. |
You might need to erase the build directory of |
|
Maybe @gregsharp knows the reason of the Plastimatch build errors when using SuperBuild=off |
That works! After pull and rebuild, SlicerRT compiles and runs without errors. |
|
Build works on Windows as well. The problem with finding the DLL is still there though. This is the error at startup. It seems the Beams module cannot locate the IEC dll. |
|
Thanks Csaba for checking. I don't have Windows, so it's hard for me to debug, but could you try adding: or
to see if things improve? I copied that snippet from https://github.com/Slicer/Slicer/blob/main/CMake/SlicerMacroBuildModuleVTKLibrary.cmake#L125 so maybe another option would be to directly copy-paste that full CMake macro instead? |
|
Neither option helped unfortunately. I printed the directory path and saw that the configuration was missing (DLL was inside a |
|
Thanks a lot Csaba for checking! Last attempt: does it work if you specify this flag as the hard-coded path where the dlls are found? https://cmake.org/cmake/help/latest/prop_tgt/BUILD_RPATH.html |
|
Sorry @ferdymercury I'm extremely busy these days, and I have been postponing this because it seems I'd need to look into it in detail and it could take an hour or two. Do you happen to have a more concrete suggestion what to try? Then I can help in a more timely manner. |
|
No hurries and thanks for the reply. I am sorry not to be a very good helping hand here, as I am no Windows expert. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@cpinter
These commits were authored by @TrosnyogoSzakoca. I just tried rebasing it to current tip of master branch trying to fix merge conflicts due to the recent bugfixes by @MichaelColonel (thanks!!).
This should not be merged yet, as according to Mark, there are some problem with finding dlls in Windows (and on my side on Linux it runs well).
Comments/ideas are welcome.
Fixes EBATINCA/RadiotherapyTransformsIEC#19