Matter Switch: Update find default endpoint #2155
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Invitation URL: |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against fd2bb89 |
|
Wouldn't the default endpoint always be the first switch (or button if there are no switches) endpoint? Child devices would be created for any additional endpoints that implement OnOff |
|
Not sure exactly what you're asking @nickolas-deboom, sorry. The default endpoint shouldn't have to be the first endpoint that implements onOff in all cases, but as it stands that's basically how it is, which in general is not correct. For now, it works, but it may not work in all cases. |
| -- Return the first switch endpoint as the default endpoint if no button endpoints are present | ||
| if #button_eps == 0 and #switch_eps > 0 then | ||
| return get_first_non_zero_endpoint(switch_eps) | ||
| if #switch_eps then |
There was a problem hiding this comment.
Suggested change
| if #switch_eps then | |
| if #switch_eps > 0 then |
You might need > 0 since 0 would evaluate to true
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR aims to expand and clarify the use of find_default_endpoint in the matter switch driver. At the moment, nothing should change as far as logic, but this will create a more extensible system moving forward.
This builds on top of the plug-energy PR, but technically does not need to.
Summary of Completed Tests