Bump minimum python version to 3.8 and Upgrade pantsbuild to 2.17 #6118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update lockfiles except for st2 which is having an issue that I hope will be resolved after upgrading pants to even newer versions. Lockfile diff: lockfiles/pytest.lock [pytest] == Upgraded dependencies == icdiff 2.0.6 --> 2.0.7 pygal 3.0.0 --> 3.0.1 Lockfile diff: lockfiles/twine.lock [twine] == Upgraded dependencies == certifi 2023.7.22 --> 2023.11.17 idna 3.4 --> 3.6 urllib3 1.26.16 --> 1.26.18 Lockfile diff: lockfiles/bandit.lock [bandit] == Upgraded dependencies == pbr 5.11.1 --> 6.0.0 Lockfile diff: lockfiles/pants-plugins.lock [pants-plugins] == Upgraded dependencies == attrs 23.1.0 --> 23.2.0 certifi 2023.7.22 --> 2023.11.17 charset-normalizer 3.2.0 --> 3.3.2 idna 3.4 --> 3.6 pantsbuild-pants 2.16.1rc0 --> 2.16.1 pantsbuild-pants-testutil 2.16.1rc0 --> 2.16.1 urllib3 1.26.16 --> 1.26.18
The old ./pants script is deprecated upstream. The new pants binary is much faster and handles bootstrapping the version of python used by pants itself. For many projects, that means the interpreter_constraints of pants are irrelevant for in-repo python code. But, we have in-repo pants-plugins, so we still have to keep our tool lockfiles compatible with pants code. documentaiton: https://www.pantsbuild.org/2.18/docs/getting-started/installing-pants local copy of get-pants.sh downloaded from: https://static.pantsbuild.org/setup/get-pants.sh (Pants is Apache 2.0 licensed)
Update lockfiles except for st2 Lockfile diff: lockfiles/pants-plugins.lock [pants-plugins] == Upgraded dependencies == pantsbuild-pants 2.16.1 --> 2.17.1 pantsbuild-pants-testutil 2.16.1 --> 2.17.1 pex 2.1.134 --> 2.1.137 == Added dependencies == node-semver 0.9.0 == Removed dependencies == certifi 2023.11.17 charset-normalizer 3.3.2 humbug 0.2.7 idna 3.6 requests 2.31.0 urllib3 1.26.18
Lockfile diff: lockfiles/flake8.lock [flake8] == Upgraded dependencies == setuptools 59.6.0 --> 69.0.3 == Removed dependencies == importlib-metadata 4.2.0 typing-extensions 4.1.1 zipp 3.6.0 Lockfile diff: lockfiles/bandit.lock [bandit] == Upgraded dependencies == gitdb 4.0.9 --> 4.0.11 setuptools 59.6.0 --> 69.0.3 smmap 5.0.0 --> 5.0.1 stevedore 3.5.2 --> 5.1.0 == Removed dependencies == importlib-metadata 4.8.3 typing-extensions 4.1.1 zipp 3.6.0 Lockfile diff: lockfiles/twine.lock [twine] == Upgraded dependencies == cffi 1.15.1 --> 1.16.0 charset-normalizer 2.0.12 --> 3.3.2 colorama 0.4.5 --> 0.4.6 cryptography 40.0.2 --> 42.0.1 docutils 0.18.1 --> 0.20.1 importlib-metadata 4.8.3 --> 7.0.1 importlib-resources 5.4.0 --> 6.1.1 jeepney 0.7.1 --> 0.8.0 keyring 23.4.1 --> 24.3.0 pygments 2.14.0 --> 2.17.2 readme-renderer 34.0 --> 42.0 requests 2.27.1 --> 2.31.0 rfc3986 1.5.0 --> 2.0.0 tqdm 4.64.1 --> 4.66.1 urllib3 1.26.18 --> 2.1.0 zipp 3.6.0 --> 3.17.0 == Added dependencies == jaraco-classes 3.3.0 more-itertools 10.2.0 nh3 0.2.15 == Removed dependencies == bleach 4.1.0 packaging 21.3 pyparsing 3.0.7 six 1.16.0 typing-extensions 4.1.1 webencodings 0.5.1 Lockfile diff: lockfiles/black.lock [black] == Upgraded dependencies == click 8.0.4 --> 8.1.7 pathspec 0.9.0 --> 0.12.1 platformdirs 2.4.0 --> 4.1.0 tomli 1.2.3 --> 2.0.1 typing-extensions 4.1.1 --> 4.9.0 == Removed dependencies == dataclasses 0.6 importlib-metadata 4.8.3 typed-ast 1.5.5 zipp 3.6.0 Lockfile diff: lockfiles/pylint.lock [pylint] == Upgraded dependencies == isort 5.8.0 --> 5.13.2 lazy-object-proxy 1.7.1 --> 1.10.0 setuptools 59.6.0 --> 69.0.3 == Removed dependencies == typed-ast 1.4.3 Lockfile diff: lockfiles/pytest.lock [pytest] == Upgraded dependencies == attrs 22.2.0 --> 23.2.0 coverage 6.2 --> 7.4.1 execnet 1.9.0 --> 2.0.2 importlib-metadata 4.8.3 --> 7.0.1 iniconfig 1.1.1 --> 2.0.0 packaging 21.3 --> 23.2 pluggy 1.0.0 --> 1.4.0 pygal 3.0.1 --> 3.0.4 pygments 2.14.0 --> 2.17.2 pytest-forked 1.4.0 --> 1.6.0 pytest-icdiff 0.6 --> 0.9 tomli 1.2.3 --> 2.0.1 zipp 3.6.0 --> 3.17.0 == Removed dependencies == pyparsing 3.0.7 typing-extensions 4.1.1
This allows us to get rid of python 3.7 in all of the tool lockfiles. Lockfile diff: lockfiles/pants-plugins.lock [pants-plugins] == Upgraded dependencies == pluggy 1.2.0 --> 1.4.0 ujson 5.7.0 --> 5.9.0 == Removed dependencies == importlib-metadata 6.7.0 zipp 3.15.0
pull-request-size
bot
added
the
size/XXL
nzlosh
approved these changes
Jan 28, 2024
amanda11
approved these changes
Jan 29, 2024
amanda11
reviewed
Jan 29, 2024
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
cognifloyd
changed the title
v4 adds several new schemas changing the default behavior of some of the validators. So, care needs to be taken during upgrade.
cognifloyd
force-pushed
the
pants-upgrade
branch
from
34d831c to
591e0cd
Compare
The action_params schema defines the "type" property as:
anyOf: [{enum: [string, object, ...]}]
jsonschema v2.6.0 reported the anyOf error "matched none of the schemas"
jsonschema v3.2.0 is a bit more helpful by reporting the underlying enum
error.
I also looked at removing the anyOf (since there is only one entry), but
the anyOf makes it easier to compare our action_params schema with the
draft4 schema to make the differences very clear.
cognifloyd
force-pushed
the
pants-upgrade
branch
from
591e0cd to
620e90b
Compare
|
I'm merging this. Hopefuly subsequent PRs won't be so big... |
|
Nice job! Thanks @cognifloyd |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
./pantsscript topantsbinary downloaded with./get-pants.sh.