[BugFix] The update_config interface still returns success after the dynamic parameter setup fails. #50821

zhangheihei · 2024-09-08T13:59:50Z

Why I'm doing:

What I'm doing:

Fixes #50822

What type of PR is this:

Does this PR entail a change in behavior?

Yes, this PR will result in a change in behavior.
No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

Interface/UI changes: syntax, type conversion, expression evaluation, display information
Parameter changes: default values, similar parameters but with different default values
Policy changes: use new policy to replace old one, functionality automatically enabled
Feature removed
Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

I have added test cases for my bug fix or my new feature
This pr needs user documentation (for new or modified features or behaviors)
- I have added documentation for my new feature or new function
This is a backport pr

Bugfix cherry-pick branch check:

…dynamic parameter interface setup fails. Signed-off-by: edwinhzhang <[email protected]>

Signed-off-by: zhanghe <[email protected]>

Signed-off-by: edwinhzhang <[email protected]>

github-actions · 2024-11-01T12:16:47Z

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

github-actions · 2024-11-01T12:16:50Z

[FE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

github-actions · 2024-11-01T12:27:18Z

[BE Incremental Coverage Report]

❌ fail : 56 / 115 (48.70%)

file detail

	path	covered_line	new_line	coverage	not_covered_line_detail
🔵	be/src/http/action/update_config_action.cpp	41	98	41.84%	[85, 91, 101, 113, 115, 123, 125, 126, 130, 131, 132, 134, 139, 141, 143, 145, 146, 148, 151, 157, 164, 166, 169, 172, 175, 179, 182, 186, 191, 192, 197, 202, 207, 211, 216, 223, 227, 232, 236, 237, 240, 241, 244, 245, 253, 257, 264, 269, 273, 277, 297, 303, 310, 347, 348, 349, 351]
🔵	be/src/common/configbase.cpp	15	17	88.24%	[257, 261]

github-actions · 2024-11-06T04:34:24Z

@Mergifyio backport branch-3.3

github-actions · 2024-11-06T04:34:25Z

@Mergifyio backport branch-3.2

mergify · 2024-11-06T04:34:28Z

backport branch-3.3

✅ Backports have been created

#52661 [BugFix] The update_config interface still returns success after the dynamic parameter setup fails. (backport #50821) has been created for branch branch-3.3

mergify · 2024-11-06T04:34:29Z

backport branch-3.2

✅ Backports have been created

#52662 [BugFix] The update_config interface still returns success after the dynamic parameter setup fails. (backport #50821) has been created for branch branch-3.2 but encountered conflicts

…dynamic parameter setup fails. (#50821) Signed-off-by: edwinhzhang <[email protected]> Signed-off-by: zhanghe <[email protected]> (cherry picked from commit 9bf5523)

…dynamic parameter setup fails. (#50821) Signed-off-by: edwinhzhang <[email protected]> Signed-off-by: zhanghe <[email protected]> (cherry picked from commit 9bf5523) # Conflicts: # be/src/http/action/update_config_action.cpp

…dynamic parameter setup fails. (backport #50821) (#52661) Co-authored-by: zhanghe <[email protected]>

…dynamic parameter setup fails. (StarRocks#50821) Signed-off-by: edwinhzhang <[email protected]> Signed-off-by: zhanghe <[email protected]> Signed-off-by: zhiminr.ren <[email protected]>

zhangheihei requested review from a team as code owners September 8, 2024 13:59

[BugFix] The update_config interface still returns success after the …

618d424

…dynamic parameter interface setup fails. Signed-off-by: edwinhzhang <[email protected]>

mergify bot assigned zhangheihei Sep 8, 2024

github-actions bot added the behavior_changed label Sep 8, 2024

zhangheihei force-pushed the bugfix-dynamic-set-config branch from d7aa036 to 618d424 Compare September 8, 2024 14:00

github-actions bot added 3.3 3.2 3.1 labels Sep 8, 2024

zhangheihei changed the title ~~[BugFix] The update_config interface still returns success after the dynamic parameter interface setup fails.~~ [BugFix] The update_config interface still returns success after the dynamic parameter setup fails. Sep 8, 2024

zhangheihei added 2 commits September 8, 2024 22:12

Merge branch 'main' into bugfix-dynamic-set-config

bcb929d

Signed-off-by: zhanghe <[email protected]>

fix placement

0de0301

Signed-off-by: edwinhzhang <[email protected]>

zhangheihei force-pushed the bugfix-dynamic-set-config branch from d5365cf to 0de0301 Compare September 8, 2024 14:19

fix clang format

1b925ba

Signed-off-by: edwinhzhang <[email protected]>

zhangheihei force-pushed the bugfix-dynamic-set-config branch from 1946736 to 1b925ba Compare September 9, 2024 02:10

fix ut

397f5c1

Signed-off-by: edwinhzhang <[email protected]>

zhangheihei force-pushed the bugfix-dynamic-set-config branch from 4aa3a28 to 397f5c1 Compare September 9, 2024 03:33

fix ut

fa2995f

Signed-off-by: edwinhzhang <[email protected]>

zhangheihei force-pushed the bugfix-dynamic-set-config branch from 53cd41a to fa2995f Compare September 9, 2024 03:50

fix ut

8a5eeaa

Signed-off-by: edwinhzhang <[email protected]>

zhangheihei force-pushed the bugfix-dynamic-set-config branch from 893e8d8 to 8a5eeaa Compare September 9, 2024 04:28

fix ut

d692f88

Signed-off-by: edwinhzhang <[email protected]>

zhangheihei force-pushed the bugfix-dynamic-set-config branch from 8efe472 to d692f88 Compare September 9, 2024 06:18

fix merge confilct

058270d

Signed-off-by: edwinhzhang <[email protected]>

zhangheihei force-pushed the bugfix-dynamic-set-config branch from ef1ad9f to 058270d Compare September 9, 2024 06:35

fix merge confilct

0f41147

Signed-off-by: edwinhzhang <[email protected]>

zhangheihei force-pushed the bugfix-dynamic-set-config branch from 374629a to 0f41147 Compare September 9, 2024 06:47

fix BE UT

e629b7a

Signed-off-by: edwinhzhang <[email protected]>

zhangheihei force-pushed the bugfix-dynamic-set-config branch from 6a91430 to e629b7a Compare September 9, 2024 08:01

fix BE UT

580335d

Signed-off-by: edwinhzhang <[email protected]>

zhangheihei force-pushed the bugfix-dynamic-set-config branch from a71e058 to fbc9bd8 Compare October 30, 2024 08:12

kevincai previously approved these changes Oct 30, 2024

View reviewed changes

zhangheihei dismissed kevincai’s stale review via 482340d October 30, 2024 09:14

fix clang format

e0aa3b6

Signed-off-by: edwinhzhang <[email protected]>

zhangheihei force-pushed the bugfix-dynamic-set-config branch from 482340d to e0aa3b6 Compare October 30, 2024 09:14

fix clang format

a4d1d3e

Signed-off-by: edwinhzhang <[email protected]>

zhangheihei force-pushed the bugfix-dynamic-set-config branch from 431d480 to a4d1d3e Compare November 1, 2024 10:17

kevincai approved these changes Nov 6, 2024

View reviewed changes

github-actions bot removed the 3.1 label Nov 6, 2024

dirtysalt approved these changes Nov 6, 2024

View reviewed changes

dirtysalt enabled auto-merge (squash) November 6, 2024 03:23

alvin-celerdata disabled auto-merge November 6, 2024 04:34

alvin-celerdata merged commit 9bf5523 into StarRocks:main Nov 6, 2024
52 of 53 checks passed

github-actions bot removed 3.3 3.2 labels Nov 6, 2024

mergify bot mentioned this pull request Nov 6, 2024

[BugFix] The update_config interface still returns success after the dynamic parameter setup fails. (backport #50821) #52661

Merged

42 tasks

mergify bot mentioned this pull request Nov 6, 2024

[BugFix] The update_config interface still returns success after the dynamic parameter setup fails. (backport #50821) #52662

Closed

42 tasks

wanpengfei-git pushed a commit that referenced this pull request Nov 6, 2024

[BugFix] The update_config interface still returns success after the …

153c725

…dynamic parameter setup fails. (backport #50821) (#52661) Co-authored-by: zhanghe <[email protected]>

github-actions bot added the 3.3-merged label Nov 6, 2024

github-actions bot added the 3.3 label Nov 9, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[BugFix] The update_config interface still returns success after the dynamic parameter setup fails. #50821

[BugFix] The update_config interface still returns success after the dynamic parameter setup fails. #50821

zhangheihei commented Sep 8, 2024 •

edited by kevincai

Loading

github-actions bot commented Nov 1, 2024

github-actions bot commented Nov 1, 2024

github-actions bot commented Nov 1, 2024

github-actions bot commented Nov 6, 2024

github-actions bot commented Nov 6, 2024

mergify bot commented Nov 6, 2024 •

edited

Loading

mergify bot commented Nov 6, 2024 •

edited

Loading

[BugFix] The update_config interface still returns success after the dynamic parameter setup fails. #50821

[BugFix] The update_config interface still returns success after the dynamic parameter setup fails. #50821

Conversation

zhangheihei commented Sep 8, 2024 • edited by kevincai Loading

Why I'm doing:

What I'm doing:

What type of PR is this:

Checklist:

Bugfix cherry-pick branch check:

github-actions bot commented Nov 1, 2024

[Java-Extensions Incremental Coverage Report]

github-actions bot commented Nov 1, 2024

[FE Incremental Coverage Report]

github-actions bot commented Nov 1, 2024

[BE Incremental Coverage Report]

file detail

github-actions bot commented Nov 6, 2024

github-actions bot commented Nov 6, 2024

mergify bot commented Nov 6, 2024 • edited Loading

✅ Backports have been created

mergify bot commented Nov 6, 2024 • edited Loading

✅ Backports have been created

zhangheihei commented Sep 8, 2024 •

edited by kevincai

Loading

mergify bot commented Nov 6, 2024 •

edited

Loading

mergify bot commented Nov 6, 2024 •

edited

Loading