Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] The update_config interface still returns success after the dynamic parameter setup fails. (backport #50821) #52661

Merged
merged 1 commit into from
Nov 6, 2024
Merged

[BugFix] The update_config interface still returns success after the dynamic parameter setup fails. (backport #50821) #52661

merged 1 commit into from
Nov 6, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Nov 6, 2024 •
edited by wanpengfei-git
Loading

Why I'm doing:

What I'm doing:

Fixes #50822

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5
This is an automatic backport of pull request #50821 done by [Mergify](https://mergify.com). ## Why I'm doing:

What I'm doing:

Fixes #50822

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

@zhangheihei @mergify
[BugFix] The update_config interface still returns success after the …
46b3e1c 
…dynamic parameter setup fails. (#50821)

Signed-off-by: edwinhzhang <[email protected]>
Signed-off-by: zhanghe <[email protected]>
(cherry picked from commit 9bf5523)
@mergify mergify bot mentioned this pull request Nov 6, 2024
Merged
24 tasks
@wanpengfei-git wanpengfei-git enabled auto-merge (squash) November 6, 2024 04:35
@wanpengfei-git wanpengfei-git merged commit 153c725 into branch-3.3 Nov 6, 2024
33 checks passed
@wanpengfei-git wanpengfei-git deleted the mergify/bp/branch-3.3/pr-50821 branch November 6, 2024 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevincai kevincai kevincai approved these changes

Assignees
No one assigned
Labels
automerge behavior_changed version:3.3.6
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kevincai @wanpengfei-git @zhangheihei