Skip to content
This repository has been archived by the owner on Jan 13, 2025. It is now read-only.

add a simple method to check devices (mainly motors) for each mechanism #108

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

dejabot
Copy link
Contributor

@dejabot dejabot commented Mar 26, 2024

Description

Thought experiment to add a simple method to check devices (mainly motors for now) for each mechanism and add a CheckDevices procedure that we could call from eg DebugOI to run those checks and signal success/failure via the lights.

Could be useful for a very quick, simple pit test. Meant to complement more thorough automatic and/or manual tests.

Sending to see if students may be interested in doing something like this as part of systematizing our pit tests.

How Has This Been Tested?

Needs to be tested by:

  • adding a DebugOI integration.

  • deploying on RevA.

  • checking that if all devices are healthy, we see green.

  • checking that if a CAN bus wire or if power is disconnected for a device, we see red.

  • Unit tests: [Add your description here]

  • Simulator testing: [Add your description here]

  • On-robot bench testing: [Add your description here]

  • On-robot field testing: [Add your description here]

dejabot added 3 commits March 29, 2024 08:26
…CheckDevices procedure that checks each mechanism and signals whether or not the checks passed.
Copy link
Member

@rcahoon rcahoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm for 2024. we should reevaluate for a better-integrated code architecture in the off-season

@dejabot
Copy link
Contributor Author

dejabot commented Apr 1, 2024

thanks! agreed. this is a contained change for comp season (iff the students want to use something like this).

for off-season, I agree that we should find ways to make this procedure catalog devices to query more easily or even automatically. I'd also like to see how we can improve the logic for whether or not a device is healthy, for more devices.

@dejabot dejabot changed the title thought experiment - add a simple method to check devices (mainly motors) for each mechanism add a simple method to check devices (mainly motors) for each mechanism Apr 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants