Skip to content
This repository has been archived by the owner on Jan 13, 2025. It is now read-only.

Revisions to Status system #148

Open
wants to merge 1 commit into
base: rcahoon/mf3-rule-hierarchy
Choose a base branch
from

Conversation

rcahoon
Copy link
Member

@rcahoon rcahoon commented Dec 13, 2024

Description

  • Use static methods where possible to minimize boilerplate code: we don't need to keep writing getInstance(), and we can use import static so we don't have to keep writing StatusBus. or Conditions.
  • Remove Status parameter from Request#isDone. The isDone method can just access the StatusBus directly/statically.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Be detailed so that your code reviewer can understand exactly how much and what kinds of testing were done, and which might still be worthwhile to do.

  • Unit tests: Units tests for new functionality are included in this PR
  • Simulator testing: [Add your description here]
  • On-robot bench testing: [Add your description here]
  • On-robot field testing: [Add your description here]

@rcahoon rcahoon requested a review from dejabot December 13, 2024 08:14
@rcahoon
Copy link
Member Author

rcahoon commented Dec 14, 2024

Use mixin interface instead of static methods

@rcahoon rcahoon force-pushed the rcahoon/mf3-rule-hierarchy branch from 8fd414b to 850a86a Compare December 14, 2024 21:24
@rcahoon rcahoon force-pushed the rcahoon/mf3-statuses branch from 3abc687 to 2069112 Compare December 14, 2024 21:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants