feat(MainNavigationBar): add menu#1280
Conversation
|
Size stats
|
|
Accessibility report ℹ️ You can run this locally by executing |
|
Deploy preview for mistica-web ready! ✅ Preview Built with commit ba95563. |
|
Screenshot tests report ✔️ All passing |
|
|
||
| // first section opened | ||
| await page.click(await screen.findByRole('button', {name: 'Start'})); | ||
| expect(await page.screenshot()).toMatchImageSnapshot({failureThreshold: 0.00001}); |
There was a problem hiding this comment.
I had to add a threshold to avoid unstable behavior in the inverse version of the navbar. Same thing was required in other tests of the inverse navbar before. It seems that the small avatar has a very small diff (8 pixels) in the circular image when it's rendered in CI (we've seen this issue in the past several times).
atabel
left a comment
atabel
left a comment
There was a problem hiding this comment.
Some posible UX improvements for the future:
- when a menu is open, I'd expect the corresponding section name to be highlighted (probably with the same hover color)
- when the mouse leaves the menu, it closes immediately. I think it would be better to add a small delay to avoid unwanted closes.
# [16.5.0](v16.4.0...v16.5.0) (2024-11-18) ### Features * **Accordion, BoxedAccordion:** allow detail and right content in header ([#1290](#1290)) ([087c486](087c486)) * **HorizontalMosaic, VerticalMosaic:** allow passing gridMode information to each item ([#1289](#1289)) ([bb8852c](bb8852c)) * **MainNavigationBar:** add menu ([#1280](#1280)) ([3973ead](3973ead)) * **vivo-type:** added medium weight ([#1291](#1291)) ([8a38d2c](8a38d2c))
|
🎉 This PR is included in version 16.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
5 participants
Issue: Link
Specs: Link