-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(MainNavigationBar): add menu #1280
Merged
Merged
Changes from all commits
Commits
Show all changes
65 commits
Select commit
Hold shift + click to select a range
bbfd2df
poc desktop large menu
marcoskolodny 06ba846
cleanup
marcoskolodny a1b75d5
fixes and code updats
marcoskolodny 4851682
fix horizontal padding
marcoskolodny a75ea6f
code cleanup
marcoskolodny be5d04e
code refactor
marcoskolodny aed9219
code cleanup
marcoskolodny 05ee333
fix empty columns case
marcoskolodny 5503d0a
scroll to top of content when menu section changes
marcoskolodny 229769d
update burger menu
marcoskolodny 277a240
fix tokens
marcoskolodny 55e00cd
add extra to burger menu sections
marcoskolodny 26a4b7a
code cleanup
marcoskolodny 044d669
Merge branch 'master' of github.com:Telefonica/mistica-web into WEB-2…
marcoskolodny 82f0c6e
fix typo
marcoskolodny 8776802
code cleanup
marcoskolodny d0f1fef
add burger menu animation
marcoskolodny ab105cb
avoid menu logic for empty tabs
marcoskolodny 7947d72
code cleanup
marcoskolodny 3eab164
update logic for extra content
marcoskolodny b5e76aa
add callback to close menu when custom content is rendered
marcoskolodny d3a8bd0
fix typo
marcoskolodny 9e9538e
code cleanup
marcoskolodny 1dbffaa
implement desktop small menu
marcoskolodny e2d98f0
cleanup cod
marcoskolodny 6633955
add a11y logic
marcoskolodny 35376e6
rollback logic
marcoskolodny 75cea2d
make scroll logic more stable
marcoskolodny a848552
refactor main logic for desktop menu, add arrow logic, cleanup code a…
marcoskolodny aec3ec1
Merge branch 'master' of github.com:Telefonica/mistica-web into WEB-2…
marcoskolodny 8de72ae
add focus navigation with arrows in desktop
marcoskolodny ae21da3
add possibility of sections without custom interaction
marcoskolodny 57112f7
a11y roles and small fixes
marcoskolodny 7f36041
fix aria expanded in arrow
marcoskolodny b2fe0bb
code cleanup
marcoskolodny ea1a148
code cleanup, add snippets and update story
marcoskolodny b249589
fix role of items and add unit test
marcoskolodny 0974ed5
remove animation from small menu
marcoskolodny b3e98f4
add screenshot tests
marcoskolodny a08bfec
update snipper and add extra unit test
marcoskolodny d2dcb9a
remove portals, fix focus order in small desktop menu
marcoskolodny e18fee2
fix issues with focus, refactor main logic and add inverse screenshots
marcoskolodny 7332c8b
fix content animation and add threshold to inverse screenshot
marcoskolodny 601b11e
avoid clip-path in small menu
marcoskolodny 7631a9b
add webkit prefixed clip-path to increase browser support
marcoskolodny 7c068e0
optimize unit tests performance
marcoskolodny 90f4593
fix focus logic and right content height
marcoskolodny fc63e49
fix scroll logic
marcoskolodny 981bbd3
add debounce logic
marcoskolodny 0ac5085
fix tests
marcoskolodny 530e714
fix hover area of sections
marcoskolodny b4dfb6c
cleanup
marcoskolodny 4e5903a
Merge branch 'master' of github.com:Telefonica/mistica-web into WEB-2…
marcoskolodny 1fb9cc0
update debounce time after review with design
marcoskolodny 577fba5
fix snippet
marcoskolodny 5cb8682
fix scrolling issues in burger menu
marcoskolodny 618b0aa
cleanup code
marcoskolodny 6bdd8a3
cleanup code
marcoskolodny 638fa05
update chevron
marcoskolodny 7e29589
make small menu default
marcoskolodny 0e749dc
fix screenshots
marcoskolodny b9a0ca8
use imagePlaceholder variable in snippets
marcoskolodny dd61e23
use requestAnimationFrame for fade-in effect
marcoskolodny e8aa201
fix initial screen reader focus in mobile and paddings in burger menu…
marcoskolodny ba95563
fix snippets coding style
marcoskolodny File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file added
BIN
+23 KB
...shot-test-tsx-main-navigation-bar-inverse-with-large-menu-in-desktop-1-snap.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+23.2 KB
...shot-test-tsx-main-navigation-bar-inverse-with-small-menu-in-desktop-1-snap.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+31.7 KB
...sx-main-navigation-bar-with-large-menu-and-custom-content-in-desktop-1-snap.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+25.1 KB
...sx-main-navigation-bar-with-large-menu-and-custom-content-in-desktop-2-snap.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+19.2 KB
...sx-main-navigation-bar-with-large-menu-and-custom-content-in-desktop-3-snap.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+23.7 KB
...x-main-navigation-bar-with-large-menu-and-default-content-in-desktop-1-snap.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+22.2 KB
...x-main-navigation-bar-with-large-menu-and-default-content-in-desktop-2-snap.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+19.2 KB
...x-main-navigation-bar-with-large-menu-and-default-content-in-desktop-3-snap.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+51.8 KB
...t-tsx-main-navigation-bar-with-menu-and-custom-content-in-mobile-ios-1-snap.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+29.7 KB
...t-tsx-main-navigation-bar-with-menu-and-custom-content-in-mobile-ios-2-snap.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+38.5 KB
...t-tsx-main-navigation-bar-with-menu-and-custom-content-in-mobile-ios-3-snap.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+17.3 KB
...t-tsx-main-navigation-bar-with-menu-and-custom-content-in-mobile-ios-4-snap.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+34.2 KB
...-tsx-main-navigation-bar-with-menu-and-default-content-in-mobile-ios-1-snap.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+29.7 KB
...-tsx-main-navigation-bar-with-menu-and-default-content-in-mobile-ios-2-snap.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+31.4 KB
...-tsx-main-navigation-bar-with-menu-and-default-content-in-mobile-ios-3-snap.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+17.3 KB
...-tsx-main-navigation-bar-with-menu-and-default-content-in-mobile-ios-4-snap.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+34.1 KB
...sx-main-navigation-bar-with-small-menu-and-custom-content-in-desktop-1-snap.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+26.3 KB
...sx-main-navigation-bar-with-small-menu-and-custom-content-in-desktop-2-snap.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+19.2 KB
...sx-main-navigation-bar-with-small-menu-and-custom-content-in-desktop-3-snap.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+24 KB
...x-main-navigation-bar-with-small-menu-and-default-content-in-desktop-1-snap.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+22.3 KB
...x-main-navigation-bar-with-small-menu-and-default-content-in-desktop-2-snap.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+19.2 KB
...x-main-navigation-bar-with-small-menu-and-default-content-in-desktop-3-snap.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had to add a threshold to avoid unstable behavior in the inverse version of the navbar. Same thing was required in other tests of the inverse navbar before. It seems that the small avatar has a very small diff (8 pixels) in the circular image when it's rendered in CI (we've seen this issue in the past several times).