Improve handling of $link widget's draggable="no"#9262
Merged
Jermolene merged 2 commits intoTiddlyWiki:masterfrom Oct 29, 2025
Merged
Improve handling of $link widget's draggable="no"#9262Jermolene merged 2 commits intoTiddlyWiki:masterfrom
Jermolene merged 2 commits intoTiddlyWiki:masterfrom
Conversation
…dget's draggable attribute is set to no
✅ Deploy Preview for tiddlywiki-previews ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
@bepuzzled It appears that this is your first contribution to the project, welcome. With apologies for the bureaucracy, please could you prepare a separate PR to the 'tiddlywiki-com' branch with your signature for the Contributor License Agreement (see contributing.md). |
📊 Build Size Comparison:
|
| Branch | Size |
|---|---|
| Base (master) | 2537.6 KB |
| PR | 2537.7 KB |
Diff: ⬆️ Increase: +0.1 KB
ericshulman
changed the title
pmario
reviewed
Aug 18, 2025
indentation changed from spaces to tabs modified else statement into a else if statement for additional specificity
Member
|
Looks good to me now. |
|
bepuzzled has signed the Contributor License Agreement (see contributing.md) |
Member
|
Thanks @bepuzzled. This will be merged soon when we start merging v5.4.0 PRs. |
Member
|
Thank you @bepuzzled |
55 tasks
linonetwo
pushed a commit
to linonetwo/TiddlyWiki5
that referenced
this pull request
Nov 9, 2025
* fix to to improve browser's compliance with user's intent when the widget's draggable attribute is set to no * Update link.js with comments from the PR review indentation changed from spaces to tabs modified else statement into a else if statement for additional specificity --------- Co-authored-by: Frédéric Demers <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This basic PR intends to improve browsers compliance with user's intent when the widget's
draggableattribute is set tonoachieved by setting the resulting<a>tag'sdraggableattribute tofalse.Currently, the user's desire to disable drag and drop when creating a
<$linkwidget by specifying attributedraggable="no"does not carry this intent in the resulting HTML<atag with a matchingdraggable="false"attribute. Thus browsers still allow the user to drag the link.PR submitted following the discussion and screen captures at https://talk.tiddlywiki.org/t/question-regarding-the-link-widget-when-its-draggable-attribute-is-set-to-no/13319/4 and associated recommendation for a PR.