Skip to content

Improve handling of $link widget's draggable="no" #9262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Improve handling of $link widget's draggable="no" #9262

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b2abbf9
fix to to improve browser's compliance with user's intent when the wi…
Aug 18, 2025
e2115d2
Update link.js with comments from the PR review
bepuzzled Aug 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions core/modules/widgets/link.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,10 @@ LinkWidget.prototype.renderLink = function(parent,nextSibling) {
dragTiddlerFn: function() {return self.to;},
widget: this
});
} else {
Copy link
Member

@pmario pmario Aug 18, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In TW we use tabs for indentation. So you need to convert the spaces.
There also needs to be an else if(this.draggable === "no") otherwise any draggable parameter will add draggable=false

So draggable="noABC" will also deactivate dragging

//set the resulting <a> tag draggable attribute to false
//to improve browser's compliance with user's intent
domNode.setAttribute("draggable","false");
}
// Assign data- attributes
this.assignAttributes(domNode,{
Expand Down