Updated CTA card html email rendering

[sanne-san]

Ref https://linear.app/ghost/issue/PLG-336/create-cta-card-email-design

• Made the html markup more Outlook-proof
• Added a class to the visibility wrapper to be able to target it for spacing

[coderabbitai]

Walkthrough

This update involves modifications to the conditional rendering and HTML structure within the call-to-action renderer and a minor styling update in the visibility utility. In the calltoaction-renderer.js file, the ctaCardTemplate and emailCTATemplate functions have been adjusted so that elements related to dataset.textValue and dataset.showButton are only rendered when appropriate, using nested conditional structures and a refined table layout for email rendering. Additional classes are now applied conditionally based on dataset properties (such as hasSponsorLabel) to allow for more dynamic styling. Additionally, in visibility.js, the _renderWithEmailVisibility function now appends the kg-visibility-wrapper class to the container element, ensuring that the container has the expected styling for email visibility.

Possibly related PRs

• Added visibility rendering to Call to Action card #1436: Addresses modifications in the renderCallToActionNode function, incorporating visibility rendering logic that ties directly to these changes.
• Updated html markup for CTA card frontend rendering #1442: Focuses on changes to the ctaCardTemplate and emailCTATemplate functions, directly relating to the enhanced HTML structure and conditional rendering improvements.
• Added CallToAction Lexical Nodes #1412: Involves the rendering logic of the CallToActionNode, which is directly tied to the modifications made in the calltoaction-renderer.js file, as both involve handling the same dataset properties for rendering.

Suggested reviewers

• ronaldlangeveld

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bfe9681 and 52e0178.

📒 Files selected for processing (1)

• packages/kg-default-nodes/test/nodes/html.test.js (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (2)

• GitHub Check: Node 22.13.1
• GitHub Check: Node 20.11.1

🔇 Additional comments (1)

packages/kg-default-nodes/test/nodes/html.test.js (1)

274-274:

✅ Verification successful

LGTM! Test case updated to verify new visibility wrapper class.

The test case correctly verifies that the kg-visibility-wrapper class is added to the visibility container in email rendering when a segment is present.

Let's verify that this is the only test case needed for the new class by checking for other potential test scenarios:

---

🏁 Script executed:

#!/bin/bash
# Search for other test cases that might need updating for kg-visibility-wrapper
rg -l "kg-visibility-wrapper" "packages/kg-default-nodes/test"

Length of output: 110

---

LGTM! The updated test in packages/kg-default-nodes/test/nodes/html.test.js accurately verifies that the new kg-visibility-wrapper class is added to the email rendering container when a segment is present. Verification indicates no other tests require updates.

✨ Finishing Touches

• 📝 Generate Docstrings (Beta)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.