Fix @turf/isobands issue with ring nesting logic #2925
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfedderly
force-pushed
the
mf/isobands-ring-nesting-fix
branch
from
ea00ac2 to
5ca0612
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working on removing marchingsquares, I noticed that the output of one of the isobands tests looked a bit strange in both the before and after versions of my change. When looking closer it was incorrectly nesting 'outer' ring polygons inside holes of other polygons. This breaks any donut-shaped bands.
Here's the matrix2 input data
Here's the original output showing the oddly shaped polygons that caught my attention.
Here's the version after the fix, which makes more sense:
