Skip to content

Testing removing existing Cookie and adding Cookiebot - note using te… #6486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 4, 2025
Merged

Testing removing existing Cookie and adding Cookiebot - note using te… #6486

merged 6 commits into from
Jun 4, 2025

Conversation

scott-tyk-web
Copy link
Collaborator

@scott-tyk-web scott-tyk-web commented May 30, 2025 •
edited by github-actions bot
Loading

User description

…st GTM at the moment do not out live

Preview Link

Checklist

  • Added a preview link
  • Reviewed AI PR Agent suggestions
  • For Tyk Members - Added Jira DX PR ticket to the subject
  • For Tyk Members - Added the appropriate release labels (for fixes add the latest release)

New Contributors

PR Type

enhancement

Description

  • Replaced existing Google Tag Manager (GTM) container IDs with new ones

  • Removed conditional GTM loading based on cookie consent

  • Commented out the legacy cookie notice partial

  • Updated GTM script to always load asynchronously

Changes walkthrough 📝

Relevant files
Enhancement
baseof.html
Update GTM noscript and disable legacy cookie notice         

tyk-docs/themes/tykio/layouts/_default/baseof.html

  • Changed GTM noscript iframe to use new container ID
  • Commented out the inclusion of the cookie notice partial
    		• +3/-8     
    head_tracking.html
    Simplify GTM script and update container ID                           

    tyk-docs/themes/tykio/layouts/partials/head_tracking.html

  • Replaced conditional GTM script with always-on async GTM using new
    container ID
  • Removed logic that checked for cookie consent before loading GTM
    		• +7/-14   
    Need help?
  • Type /help how to ... in the comments thread for any questions about PR-Agent usage.
  • Check out the documentation for more information.
    •

    @scott-tyk-web
    Copy link
    Collaborator Author

    Do not merge this yet! This is just for testing.

    @github-actions GitHub Actions
    Copy link
    Contributor

    ⚠️ Deploy preview for PR #6486 did not become live after 3 attempts.
    Please check Netlify or try manually: Preview URL

    @github-actions GitHub Actions
    Copy link
    Contributor

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Consent Handling Removed

    The conditional loading of Google Tag Manager based on cookie consent has been removed. This means GTM will now always load, regardless of user consent, which may have privacy and compliance implications.

     
    <!-- Google Tag Manager -->
<script>(function(w,d,s,l,i){w[l]=w[l]||[];w[l].push({'gtm.start':
new Date().getTime(),event:'gtm.js'});var f=d.getElementsByTagName(s)[0],
j=d.createElement(s),dl=l!='dataLayer'?'&l='+l:'';j.async=true;j.src=
'https://www.googletagmanager.com/gtm.js?id='+i+dl;f.parentNode.insertBefore(j,f);
})(window,document,'script','dataLayer','GTM-K5PPWPH7');</script>
<!-- End Google Tag Manager -->
    Cookie Notice Disabled

    The cookie notice partial is now commented out, so users will not be notified or able to manage cookie preferences. This could affect legal compliance and user transparency.

     
    <!-- {{ partial "cookie_notice.html" . }} -->

    @github-actions GitHub Actions
    Copy link
    Contributor

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    @netlify Netlify
    Copy link

    netlify bot commented May 30, 2025

    ✅ PS. Add to the end of url /docs/nightly

    Name Link
    🔨 Latest commit 1fbc33d
    🔍 Latest deploy log https://app.netlify.com/projects/tyk-docs/deploys/683987760cbf920008e9b264
    😎 Deploy Preview https://deploy-preview-6486--tyk-docs.netlify.app
    📱 Preview on mobile
    Toggle QR Code...

    QR Code

    Use your smartphone camera to open QR code link.

    To edit notification comments on pull requests, go to your Netlify project configuration.

    @netlify Netlify
    Copy link

    netlify bot commented May 30, 2025 •
    edited
    Loading

    ✅ PS. Add to the end of url /docs/nightly

    Name Link
    🔨 Latest commit 01c067b
    🔍 Latest deploy log https://app.netlify.com/projects/tyk-docs/deploys/684004762d6bee0008f2d4e0
    😎 Deploy Preview https://deploy-preview-6486--tyk-docs.netlify.app
    📱 Preview on mobile
    Toggle QR Code...

    QR Code

    Use your smartphone camera to open QR code link.

    To edit notification comments on pull requests, go to your Netlify project configuration.

    @scott-tyk-web
    Copy link
    Collaborator Author

    Heads up for this one now. I am currently planing to push the changes for this live on the live marketing site and GTM container on Wednesday afternoon. Therefore it would be good to get the reviewed and then arrange a good time for it to be merged in around that time so the docs site is changed over at the same time. Otherwise some tags would stop working on the docs pages.

    Thanks

    letzya
    letzya reviewed Jun 2, 2025
    View reviewed changes
    letzya
    letzya approved these changes Jun 2, 2025
    View reviewed changes
    Copy link
    Collaborator

    @letzya letzya left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    All good

    @yurisasuke yurisasuke merged commit 0dd3b7d into master Jun 4, 2025
    12 checks passed
    @yurisasuke yurisasuke deleted the feature/new-cmp branch June 4, 2025 11:06
    @sharadregoti
    Copy link
    Contributor

    /release to release-5.7

    @sharadregoti
    Copy link
    Contributor

    /release to release-5.6

    @sharadregoti
    Copy link
    Contributor

    /release to release-5.8

    @tykbot tykbot
    Copy link
    Contributor

    tykbot bot commented Jun 4, 2025

    Working on it! Note that it can take a few minutes.

    2 similar comments
    @tykbot tykbot
    Copy link
    Contributor

    tykbot bot commented Jun 4, 2025

    Working on it! Note that it can take a few minutes.

    @tykbot tykbot
    Copy link
    Contributor

    tykbot bot commented Jun 4, 2025

    Working on it! Note that it can take a few minutes.

    tykbot bot pushed a commit that referenced this pull request Jun 4, 2025
    @scott-tyk-web
    Testing removing existing Cookie and adding Cookiebot - note using te… (
    ac460a2 
    #6486)

* Testing removing existing Cookie and adding Cookiebot - note using test GTM at the moment do not out live

* switching to production GTM

* removing old files and references to them

---------

Co-authored-by: Leonid Bugaev <[email protected]>

(cherry picked from commit 0dd3b7d)
    @buger buger mentioned this pull request Jun 4, 2025
    Closed
    @tykbot tykbot
    Copy link
    Contributor

    tykbot bot commented Jun 4, 2025

    @sharadregoti Created merge PRs

    @tykbot tykbot
    Copy link
    Contributor

    tykbot bot commented Jun 4, 2025

    Still working...

    tykbot bot pushed a commit that referenced this pull request Jun 4, 2025
    @scott-tyk-web
    Testing removing existing Cookie and adding Cookiebot - note using te… (
    05651e0 
    #6486)

* Testing removing existing Cookie and adding Cookiebot - note using test GTM at the moment do not out live

* switching to production GTM

* removing old files and references to them

---------

Co-authored-by: Leonid Bugaev <[email protected]>

(cherry picked from commit 0dd3b7d)
    @tykbot tykbot
    Copy link
    Contributor

    tykbot bot commented Jun 4, 2025

    Still working...

    @buger buger mentioned this pull request Jun 4, 2025
    Closed
    @tykbot tykbot
    Copy link
    Contributor

    tykbot bot commented Jun 4, 2025

    @sharadregoti Created merge PRs

    tykbot bot pushed a commit that referenced this pull request Jun 4, 2025
    @scott-tyk-web
    Testing removing existing Cookie and adding Cookiebot - note using te… (
    760cc7b 
    #6486)

* Testing removing existing Cookie and adding Cookiebot - note using test GTM at the moment do not out live

* switching to production GTM

* removing old files and references to them

---------

Co-authored-by: Leonid Bugaev <[email protected]>

(cherry picked from commit 0dd3b7d)
    @buger buger mentioned this pull request Jun 4, 2025
    Merged
    @tykbot tykbot
    Copy link
    Contributor

    tykbot bot commented Jun 4, 2025

    @sharadregoti Created merge PRs

    buger added a commit that referenced this pull request Jun 4, 2025
    @buger
    Merging to release-5.8: Testing removing existing Cookie and adding C…
    6b0f75b 
    …ookiebot - note using te… (#6486)

Testing removing existing Cookie and adding Cookiebot - note using te… (#6486)

* Testing removing existing Cookie and adding Cookiebot - note using test GTM at the moment do not out live

* switching to production GTM

* removing old files and references to them

---------

Co-authored-by: Leonid Bugaev <[email protected]>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @letzya letzya letzya approved these changes

    @yurisasuke yurisasuke yurisasuke approved these changes

    Assignees
    No one assigned
    Labels
    release-5.6 release-5.7 release-5.8 Review effort 2/5
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    5 participants
    @scott-tyk-web @sharadregoti @letzya @yurisasuke @buger