Motor driver firmware integration #3458
Draft
+2,125
−1,590
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts_crosstool_compiler
…re into tbots_crosstool_compiler
…e/Software into motor_firmware_integration
…into motor_firmware_integration
williamckha
force-pushed
the
motor_firmware_integration
branch
from
c369820 to
0982f95
Compare
itsarune
reviewed
Jul 30, 2025
itsarune
reviewed
Jul 30, 2025
itsarune
reviewed
Jul 30, 2025
4 tasks
…into motor_firmware_integration
itsarune
reviewed
Aug 23, 2025
Contributor
There was a problem hiding this comment.
Seems like an accidental change
itsarune
reviewed
Aug 23, 2025
| tx[5] = FRAME_EOF; | ||
|
|
||
| const uint8_t message[] = {tx[1], tx[2], tx[3]}; | ||
| tx[4] = Crc8Autosar::calc(message, sizeof(message)); |
Contributor
There was a problem hiding this comment.
Consider using the CRC function we've already implemented:
itsarune
reviewed
Aug 23, 2025
src/software/embedded/motor_controller/stspin_motor_controller.cpp
Outdated
Show resolved
Hide resolved
itsarune
reviewed
Aug 23, 2025
| // TODO (#2720): compute from robot constants (this was computed by hand and is | ||
| // accurate) | ||
| static constexpr double MECHANICAL_MPS_PER_ELECTRICAL_RPM = 0.000111; | ||
| #ifdef TRINAMIC_MOTOR_BOARD |
Contributor
There was a problem hiding this comment.
Move this to pi_constants.h and jetson_constants.h
itsarune
reviewed
Aug 23, 2025
itsarune
reviewed
Aug 23, 2025
Contributor
There was a problem hiding this comment.
Revert changes in this file
…into motor_firmware_integration # Conflicts: # src/WORKSPACE # src/shared/2021_robot_constants.cpp # src/software/embedded/services/motor.cpp # src/software/embedded/services/robot_auto_test.cpp
itsarune
reviewed
Nov 4, 2025
src/software/embedded/motor_controller/stspin_motor_controller.cpp
Outdated
Show resolved
Hide resolved
itsarune
reviewed
Nov 4, 2025
src/software/embedded/motor_controller/tmc_motor_controller.cpp
Outdated
Show resolved
Hide resolved
itsarune
reviewed
Nov 11, 2025
itsarune
reviewed
Nov 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please fill out the following before requesting review on this PR
Description
Testing Done
Resolved Issues
Length Justification and Key Files to Review
Review Checklist
It is the reviewers responsibility to also make sure every item here has been covered
.hfile) should have a javadoc style comment at the start of them. For examples, see the functions defined inthunderbots/software/geom. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.TODO(or similar) statements should either be completed or associated with a github issue