Fsm debug window #3489
Draft
Fsm debug window #3489
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itsarune
reviewed
Oct 19, 2025
itsarune
reviewed
Oct 19, 2025
itsarune
reviewed
Oct 19, 2025
itsarune
reviewed
Oct 19, 2025
itsarune
reviewed
Oct 19, 2025
itsarune
reviewed
Oct 19, 2025
| * Creates a tactic given a tactic proto | ||
| * | ||
| * @param tactic_proto the tactic proto | ||
| * @param ai_config The AI config |
Contributor
There was a problem hiding this comment.
Suggested change
| * @param ai_config_ptr The AI config |
itsarune
reviewed
Oct 19, 2025
| /** | ||
| * Update the AiConfig proto | ||
| * | ||
| * @param ai_config The new AiConfig proto |
itsarune
reviewed
Oct 19, 2025
itsarune
reviewed
Oct 19, 2025
Comment on lines
+32
to
+41
| FSMLogger() : robot_id(std::nullopt){}; | ||
|
|
||
| /** | ||
| * Set the associated robot ID | ||
| * | ||
| * @param robot_id the id of the robot that the associated tactic is running on | ||
| */ | ||
| void setRobotId(std::optional<unsigned int> robot_id) { | ||
| this->robot_id = robot_id; | ||
| } |
Contributor
There was a problem hiding this comment.
Move implementation to sml_fsm.cpp
itsarune
reviewed
Oct 19, 2025
itsarune
reviewed
Oct 19, 2025
itsarune
reviewed
Oct 19, 2025
| * @param result true if the guard passed, false if the guard failed | ||
| */ | ||
| template <class SM, class TGuard, class TEvent> | ||
| void log_guard(const TGuard&, const TEvent&, bool result) |
Contributor
There was a problem hiding this comment.
is TGuard and TEvent parameters from the SML library? What information do they contain?
itsarune
reviewed
Oct 19, 2025
itsarune
reviewed
Oct 19, 2025
| */ | ||
| explicit FSMLogger(std::optional<unsigned int> robot_id) : robot_id(robot_id) {} | ||
|
|
||
| FSMLogger() : robot_id(std::nullopt){}; |
itsarune
reviewed
Oct 19, 2025
| tactic_transitions.append(playinfo.robot_tactic_assignment[robot_id].last_transition) | ||
| tactic_names.append(playinfo.robot_tactic_assignment[robot_id].tactic_name) | ||
|
|
||
| set_table_data( |
Contributor
There was a problem hiding this comment.
This works great! Is there a way to try to make the column lengths fixed? They are hard to track when using AI vs AI
itsarune
reviewed
Oct 19, 2025
Contributor
itsarune
left a comment
itsarune
left a comment
There was a problem hiding this comment.
Looks like a great debug tool!
It's a bit annoying that the column widths are constantly changing on Thunderscope, so it makes it a bit hard to figure out what's going on.
Contributor
Author
|
Yeah I've got some plans to make a better UI but I just have not found the time to think about it further |
…tic-and-Play-Refactor
…/Software into Tactic-and-Play-Refactor
…/Software into FSMDebugWindow
Remove experimental disk cache size and age settings.
Co-authored-by: itsarune <[email protected]>
itsarune
reviewed
Nov 18, 2025
src/.bazelrc
Outdated
Comment on lines
51
to
53
| build --experimental_disk_cache_gc_max_size=32G | ||
| build --experimental_disk_cache_gc_max_age=28d | ||
|
|
Contributor
Author
There was a problem hiding this comment.
Very much so :(
I will remove later
Co-authored-by: itsarune <[email protected]>
…tic-and-Play-Refactor
…/Software into Tactic-and-Play-Refactor
…/Software into FSMDebugWindow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is built off of PR #3481
I use Boost::SML logging capabilities to expose the guard calls and state transitions that our AI undergoes as it is moving through each state machine
Testing Done
Thunderscope runs with similar performance as before, messages seem to line up with robot id
Resolved Issues
I have no idea if this resolves any issues :/ but it will probably make debugging easier
#3532
Length Justification and Key Files to Review
Look at sml_fsm.h especially I think
Review Checklist
It is the reviewers responsibility to also make sure every item here has been covered
.hfile) should have a javadoc style comment at the start of them. For examples, see the functions defined inthunderbots/software/geom. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.TODO(or similar) statements should either be completed or associated with a github issue