Kickoff friendly play fsm cleaned #3518
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…GPIO" are now updated to "Gpio".
Fixes that need to be made in future commits: - build errors across several validation testing files - unnecessary comments need to be erased
Bugs: - several validation files don't build
…o not enter a region. Incomplete process but committing prior to laptop dying.
…umberOfRobotsEventuallyEntersRegion() as required.
…/Thunderbots-Muk into kickoff_friendly_play_fsm_cleaned
…alidation is incorrectly passed both AlwaysValidation and EventuallyValidation
…s skipped tests as failed.
…since pytest.skip() causes CI to fail.
…alidation # Conflicts: # src/software/ai/hl/stp/play/enemy_free_kick/enemy_free_kick_play_test.py
…ff_friendly_play_fsm_cleaned
…/Thunderbots-Muk into kickoff_friendly_play_fsm_cleaned
…o use updated pytests.
…friendly_play_fsm_cleaned
Muxite
requested review from
Andrewyx,
sauravbanna and
williamckha
as code owners
Andrewyx
reviewed
Nov 15, 2025
| "//software/logger", | ||
| "//software/util/generic_factory", | ||
| ], | ||
| alwayslink = True, |
Contributor
There was a problem hiding this comment.
Why does this need to be statically linked?
Andrewyx
reviewed
Nov 15, 2025
|
|
||
| void KickoffEnemyPlayFSM::createKickoffSetupPositions(const WorldPtr &world_ptr) | ||
| { | ||
| // these positions are picked according to the followicreateKickoffSetupPositions();ng slide |
Andrewyx
reviewed
Nov 15, 2025
| for (size_t i = 0; i < shadower_count; i++) | ||
| { | ||
| // Assign the first 2 robots to shadow enemies, if the enemies exist | ||
| auto enemy_threat = enemy_threats.at(i); |
Contributor
There was a problem hiding this comment.
nit: this results in a copy due to auto I think?
https://medium.com/@rogerbooth/c-gotcha-unnecessary-copies-due-to-the-misuse-of-auto-ed24e65b5efd
Might want to use explicit auto&
Contributor
|
Okay I just saw the "Don't Review Tag" If there are ANY files to review for this PR please list them explicitly in the desc. Otherwise, if this is not yet ready for a review, please convert this to a draft PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
DONT REVIEW IT
Convert kickoff-friendly-play to fsm, and convert kickoff-enemy-play to fsm, and add functionality to both.
DONT REVIEW THIS, was told to make PR to fix commit issues.
Testing Done
Need to write tests. Made this pull request to fix a lot of commit issues and compare with master.
Resolved Issues
3287 & 3296
Length Justification and Key Files to Review
stuff in kickoff_friendly and kickoff_enemy
Review Checklist
It is the reviewers responsibility to also make sure every item here has been covered
.hfile) should have a javadoc style comment at the start of them. For examples, see the functions defined inthunderbots/software/geom. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.TODO(or similar) statements should either be completed or associated with a github issue