-
Notifications
You must be signed in to change notification settings - Fork 122
Change wsl docs #3535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Change wsl docs #3535
Conversation
|
uh something is going on with commit history, lemme fix that real quick |
nycrat
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a small comment about formatting, otherwise everything looks good 👍
| - [X Server Setup](#x-server-setup) | ||
| - [Networking Issues](#networking-issues) | ||
| - [USB Issues](#usb-issues) | ||
| - [Software Setup on Windows Subsystem for Linux](#software-setup-on-windows-subsystem-for-linux) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably don't need this link, just keep the TOC consistent with the rest of the docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TOC should be auto-generated when you run lint and format script
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TOC should be auto-generated when you run lint and format script
Description
Update WSL2 docs based on personal experience. I recommend installing WSL2 in Windows 11 as it contains all the needed features.
Testing Done
Resolved Issues
Length Justification and Key Files to Review
Review Checklist
It is the reviewers responsibility to also make sure every item here has been covered
.hfile) should have a javadoc style comment at the start of them. For examples, see the functions defined inthunderbots/software/geom. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.TODO(or similar) statements should either be completed or associated with a github issue