Carousel #482
Merged
Carousel #482
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ghg-demo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
hanbyul-here
force-pushed
the
main-carousel
branch
from
d643c0a to
8f1f7d2
Compare
hanbyul-here
force-pushed
the
main-carousel
branch
from
8f1f7d2 to
09b4842
Compare
hanbyul-here
requested review from
faustoperez
and removed request for
faustoperez
hanbyul-here
added a commit
to NASA-IMPACT/veda-ui
that referenced
this pull request
Aug 15, 2024
**Related Ticket:** #1098 + We are encouraging IMPACT team to use USWDS. This new style configuration that uses grid-layout will be useful for IMPACT team. (I also need this style for Carousel ) ### Description of Changes - Added grid-layout style from uswds design system - Edited purgecss configuration to include `instance/overrides` folder as content - Added CSS Variables for VEDA customization colors. ### Notes & Questions About Changes I almost gave up getting purgecss to work, but @dzole0311 helped me figure out what was wrong. (The default extractor doesn't allow special characters like `:`, which we need to target specific screen size like `tablet: ` ex. https://designsystem.digital.gov/utilities/layout-grid/ Thank you so much 🙇 @dzole0311 ! @slesaad , you don't need to review this PR, but I think it would be beneficial to check how we are importing the styles and purging the styles through `postcss.config`. ### Validation / Testing This PR doesn't bring any visual change to UI, but this GHG pr uses this branch: US-GHG-Center/veda-config-ghg#482
hanbyul-here
force-pushed
the
main-carousel
branch
from
112e543 to
909daf7
Compare
hanbyul-here
force-pushed
the
main-carousel
branch
from
08ec988 to
8675f5c
Compare
|
@hanbyul-here should we remove the underline from the title and make the title font a bit bigger? we can merge the UI change in too (since you're pointing to main now) |
|
@slesaad Ah thanks for catching the font size. We decided to underline the title since it is an actionable item so no need for additional style there. |
dzole0311
reviewed
Aug 21, 2024
There was a problem hiding this comment.
Great job @hanbyul-here, I tested the feature and it looks and feels really nice and responsive!
slesaad
approved these changes
Aug 22, 2024
dzole0311
approved these changes
Aug 22, 2024
Merged
paridhi-parajuli
added a commit
that referenced
this pull request
Sep 18, 2024
# Description This PR holds all the big change that we'll be releasing for R3. The `feature/r3` branch is the base branch, any new updates should be merged into this branch. # All PRs: - #520 - #519 - #517 - #516 - #513 - #508 - #505 - #500 - #498 - #482 - #461 - #451 - + so many others, impossible to list them all ## Preview ### <span aria-hidden="true">✅</span> Deploy Preview for *ghg-demo* ready! | Name | Link | |:-:|------------------------| |<span aria-hidden="true">😎</span> Deploy Preview | [https://deploy-preview-484--ghg-demo.netlify.app](https://deploy-preview-484--ghg-demo.netlify.app) | |<span aria-hidden="true">📱</span> Preview on mobile | <details><summary> Toggle QR Code... </summary><br /><br /><br /><br />_Use your smartphone camera to open QR code link._</details> | --- >[!WARNING] >The deploy preview may not be recent, wait till the last commit shows ✅ below 👇 to get the latest version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close NASA-IMPACT/veda-ui#1098
I used this PR as a test-bed to figure out how to write a component using USWDS design system. The rules that I tried to stick is like below.
🤔 I think, as a team, we only agreed on 1. altogether. (And I expressed my bias towards 2.) - other steps came to be kind of natural, but this might not be the case for everybody. So let's discuss if anything doesn't look right!
@faustoperez - I made the whole (- link area) card to be clickable
This PR NASA-IMPACT/veda-ui#1112 needs to be merged first
@slesaad - 🤔 I am not sure what to do with ui module because this change does require the update of UI module. Should I let this PR sit until the next release?