[ALL] Fix color picker frame not regenerating the preview texture after being closed #1781
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… created texture handle CColorXYPreview panel is no longer trying to use decremented (invalid) texture handle from MaterialSystem
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When CProceduralTexturePanel calls it's CleanUp function it decrements the current texture handle ref index value and since the texture name never[1][2] gets changed you're left with a invalid texture until you restart the game
This fix is based on how econ deals with prodecural textures
It might be better to use a static int as a serial for the texture, but it works
Video demonstration of a bug:
colorpicker_bug.mp4
Fixed version:
colorpicker_nobug.mp4