fix: delete expirer entry after proposal response #6738
Merged
+21
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sign-client
now correctly clears theexpirer
entry when it deletes a proposal. This was resulting in an annoying error log as the expirer couldn't find its target since the proposal was already deletedType of change
How has this been tested?
tests, dogfooding
Checklist
Additional Information (Optional)
Please include any additional information that may be useful for the reviewer.