fix: delete expirer entry after proposal response

.changeset/plain-paws-happen.md

@@ -0,0 +1,12 @@
+---
+"@walletconnect/sign-client": patch
+"@walletconnect/core": patch
+"@walletconnect/react-native-compat": patch
+"@walletconnect/types": patch
+"@walletconnect/utils": patch
+"@walletconnect/ethereum-provider": patch
+"@walletconnect/signer-connection": patch
+"@walletconnect/universal-provider": patch
+---
+
+deletes expirer entry after the wallet responds to a session proposal

packages/sign-client/src/controllers/engine.ts

@@ -481,6 +481,7 @@
       metadata: proposer.metadata,
     });
     await this.client.proposal.delete(id, getSdkError("USER_DISCONNECTED"));
+    this.client.core.expirer.del(id);
     await this.client.core.pairing.activate({ topic: pairingTopic });
     await this.setExpiry(sessionTopic, calcExpiry(SESSION_EXPIRY));
     return {
@@ -515,8 +516,10 @@
         error: reason,
         rpcOpts: ENGINE_RPC_OPTS.wc_sessionPropose.reject,
       });
-      await this.client.proposal.delete(id, getSdkError("USER_DISCONNECTED"));
     }
+
+    await this.client.proposal.delete(id, getSdkError("USER_DISCONNECTED"));
+    this.client.core.expirer.del(id);
   };
 
   public update: IEngine["update"] = async (params) => {
@@ -930,7 +933,7 @@
     const authenticateEventTarget = engineEvent("session_request", authenticateId);
 
     // handle fallback session proposal response
     const onSessionConnect = async ({ error, session }: any) => {
       // cleanup listener for authenticate response
       this.events.off(authenticateEventTarget, onAuthenticate);
       if (error) reject(error);
@@ -2200,7 +2203,7 @@
     }, 500);
   };
 
   private onSessionDeleteRequest: EnginePrivate["onSessionDeleteRequest"] = async (
     topic,
     payload,
   ) => {

packages/sign-client/test/sdk/client.spec.ts

@@ -93,6 +93,10 @@ describe("Sign Client Integration", () => {
       expect(clients.B.metadata.redirect).to.exist;
       expect(clients.B.metadata.redirect?.native).to.exist;
       expect(clients.B.metadata.redirect?.universal).to.exist;
+      expect(clients.A.core.expirer.keys).to.deep.equal(clients.B.core.expirer.keys);
+      expect(clients.A.core.expirer.keys.length).to.eq(2);
+      expect(clients.B.core.expirer.keys.length).to.eq(2);
+
       await deleteClients(clients);
     });
     it("should set scopedProperties in session", async () => {