Log config options set by IPC #2714
Conversation
| { | ||
| LOGW("Config options set via IPC will not update from ", config_file_str, | ||
| " until Wayfire restart."); | ||
| warning_count++; |
There was a problem hiding this comment.
I would say we should ++warning_count every time, and when we hit MAX_WARNINGS, print a warning that we will suppress future warnings. Just so that users don't wonder why there are no subsequent warnings xd
| @@ -23,6 +23,8 @@ class ipc_rules_utility_methods_t | |||
| private: | |||
| wlr_backend *headless_backend = NULL; | |||
| std::set<uint64_t> our_outputs; | |||
| int warning_count = 0; | |||
There was a problem hiding this comment.
We should make these static variables in set_config_options, this way it is clear that they are for that IPC method only.
| @@ -281,6 +283,16 @@ class ipc_rules_utility_methods_t | |||
| return wf::ipc::json_error("Options must be an object!"); | |||
| } | |||
|
|
|||
| const char *config_file = std::getenv("WAYFIRE_CONFIG_FILE"); | |||
There was a problem hiding this comment.
I think strictly speaking we don't really need to print the config file every time, we say this at the beginning of the log. So we could just say that we won't laod from the config file. Consider that for example config backends could also use a different config file altogether not the ini file.
|
Thanks for the suggestions. We should find a better way to explain set_config_options' implications without spamming logs like add comments. |
fixes #2707
Message format:
[plugins/ipc-rules/ipc-utility-methods.hpp:287] Config options set via IPC will not update from /home/myuser/.config/wayfire.ini until Wayfire restart