Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--target can point to file directly #3

Open
wants to merge 10 commits into
base: cwl-docker-workflow
Choose a base branch
from

Conversation

michael-kotliar
Copy link

If --target points to the file, --index and --data are ignored.
Output filenames are fixed to RELI.stats and RELI.overlaps

@@ -1,10 +1,14 @@
# ================================================================
#
# Dockerfile for RELI (public release)
#
Copy link
Contributor

@ernstki ernstki Jan 30, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Misha, what's the purpose of this (the Version: 0.0.2)? I like the idea of having examples for "Build," "Pull," and "Run," but I'm trying to understand why the version tag cannot simply be latest.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If our CWL file uses latest then after updating docker container, the inputs in CWL file should be updated too. To better control the correspondence between CWL and Docker I'd rather use more specific versions instead of latest

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw, try to rebuild Dockerfile. I guess, it should me much smaller, then the original one.

@ernstki
Copy link
Contributor

ernstki commented Jan 30, 2019

@michael-kotliar If Xiaoting was okay with the changes to the -target parameter, then I'll probably need to ask you to re-apply those to a new branch and resubmit a PR on GitHub.

Please leave CMakeLists.txt in your working directory without committing it next time. I'd like to stick with standard (GNU) build tools, and we don't use CLion, so our tools don't have built-in support for CMake.

On our internal GitLab server I'm currently working through a few issues merging Xiaoting's changes that write the RSIDs of overlapping SNPs to an output file. I'll close this PR to signal that we're ready for you to fork again and re-submit a PR. Apologies for the inconvenience; we're still learning. :)

@michael-kotliar
Copy link
Author

Sure, no problem. Meanwhile, I'll add some other commits to this branch :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants