Skip to content

--target can point to file directly #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: cwl-docker-workflow
Choose a base branch
from
Open

--target can point to file directly #3

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
a2ada52
Add CMakeLists.txt file
michael-kotliar Jan 18, 2019
84f9a24
Minor args refactor
michael-kotliar Jan 18, 2019
7cccc75
Allow to set file path in --target
michael-kotliar Jan 18, 2019
6921ec8
Updated Dockerfile to point to specific version
michael-kotliar Jan 18, 2019
2cb7235
Unimportant changes
michael-kotliar Jan 18, 2019
1952f7d
Unimportant changes
michael-kotliar Jan 18, 2019
497def5
Return to one dash arguments
michael-kotliar Feb 4, 2019
1cd21c6
Decreased number of layers in Dockerfile
michael-kotliar Feb 4, 2019
695b68e
Add -prefix argument
michael-kotliar Feb 4, 2019
ec00305
Move header file to include folder
michael-kotliar Feb 14, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,14 @@
# ================================================================
#
# Dockerfile for RELI (public release)
#
Copy link
Contributor

@ernstki ernstki Jan 30, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Misha, what's the purpose of this (the Version: 0.0.2)? I like the idea of having examples for "Build," "Pull," and "Run," but I'm trying to understand why the version tag cannot simply be latest.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If our CWL file uses latest then after updating docker container, the inputs in CWL file should be updated too. To better control the correspondence between CWL and Docker I'd rather use more specific versions instead of latest

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw, try to rebuild Dockerfile. I guess, it should me much smaller, then the original one.

# Version: 0.0.2
# Author: Kevin Ernst <kevin.ernst -at- cchmc.org>
# Date: 25 July 2018
#
# Build: docker build --rm -t weirauchlab/reli:v0.0.2 -f Dockerfile .
# Pull: docker pull weirauchlab/reli:v0.0.2
# Run: docker run --rm -ti weirauchlab/reli:v0.0.2
#
# ================================================================

# start with https://store.docker.com/images/centos
Expand Down