Skip to content

WI00856226 - FluentAssertions removal from Blazor.Diagrams.Tests #51

Merged
Srude-Vena merged 4 commits intomasterfrom
Blazor/fix/WI00856226/RemoveFluentAssertions_Blazor.Diagrams.Tests
Feb 4, 2025
Merged

WI00856226 - FluentAssertions removal from Blazor.Diagrams.Tests #51
Srude-Vena merged 4 commits intomasterfrom
Blazor/fix/WI00856226/RemoveFluentAssertions_Blazor.Diagrams.Tests

Conversation

@Srude-Vena
Copy link

FluentAssertions needs to be removed from the project Blazor.Diagrams.Tests in https://github.com/WiseTechGlobal/Blazor.Diagrams/blob/master/tests/Blazor.Diagrams.Tests/Blazor.Diagrams.Tests.csproj. Please use standard assertions instead.

@LeonamAnjos LeonamAnjos changed the title WI00856226-FluentAssertions removal from Blazor.Diagrams.Tests WI00856226 - FluentAssertions removal from Blazor.Diagrams.Tests Jan 30, 2025
Copy link

@LeonamAnjos LeonamAnjos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KavishG18 KavishG18 requested review from KavishG18 and removed request for KavishG18 January 30, 2025 05:49
@@ -22,9 +22,7 @@
<PackageReference Include="Microsoft.AspNetCore.Components.Web" />
<PacakgeReference Include="Brutal.Dev.StrongNameSigner" PrivateAssets="All" />

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<PacakgeReference Include="Brutal.Dev.StrongNameSigner" PrivateAssets="All" />
<PackageReference Include="Brutal.Dev.StrongNameSigner" PrivateAssets="All" />

<Reference Include="SvgPathProperties" PrivateAssets="All">
<HintPath>..\..\packages\svgpathproperties\1.1.2\lib\netstandard2.0\SvgPathProperties.dll</HintPath>
</Reference>
<PackageReference Include="SvgPathProperties" PrivateAssets="All" />

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's fix the spacing here.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spacing fixed

Copy link

@LeonamAnjos LeonamAnjos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Srude-Vena Srude-Vena merged commit 5e6a578 into master Feb 4, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants