🚧 Experimental: Global styles revisions #49912
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
Size Change: +2.73 kB (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in f3cfeb0. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4760423685
|
Showing revisions for the wp_global_styles custom post type in the styles sidebar. We're only showing max 10 to limit the payload.
… might have different settings we'd want to reinstate. Doing a deep equality check to highlight the currently selected revision.
- Limit is 100 revisions in response Added experimental revisions selector/action/resolver to the core-data store Abstracted compare revisions into isGlobalStyleConfigEqual and added tests Showing selector control in the UI if revision count is > 10
Bumped revision count that can be returned from the API to 100
…ating the full revision. The revision should overwrite everything.
- same behaviour as post editor - since revisions includes the current saved post, so we need at least two in order to switch
…yet delete global styles revisions and, because of other tests, we can't rely on the post revisions being a certain count so we try to cater for both in the test for now. Added aria label to buttons in the UI
Checking for the number of revision buttons in the revisions list.
…rentGlobalStylesId, which has been removed in this PR. Adding a reset button.
Removing secondary button styling
Updating e2e tests A sad attempt at caching the unsaved userConfig Adding an `is_latest` prop to the rest response to indicate the latest saved revision
Redesigning the buttons view Rationalizing rest API return properties
ramonjd
force-pushed
the
try/user-global-styles-revisions-in-style-book-slot
branch
from
c33cb70
to
f3cfeb0
Compare
This was referenced Apr 21, 2023
|
This was a sandpit. 💥 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Experimental alternative for #46667
Loads current template inside an iframe (copying stylebook) so we can load and preview global styles revisions without affecting the editor canvas.
TODO:
BEHOLD THE LOOPING GIF
Why?
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast