Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚧 Experimental: Global styles revisions #49912

Closed
wants to merge 28 commits into from
Closed

🚧 Experimental: Global styles revisions #49912

wants to merge 28 commits into from

Commits on Apr 21, 2023

  1. Initial commit 

    Showing revisions for the wp_global_styles custom post type in the styles sidebar.
We're only showing max 10 to limit the payload.
    @ramonjd
    ramonjd committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    705cda0 View commit details
    Browse the repository at this point in the history

  2. Updating test

    @ramonjd
    ramonjd committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    376d279 View commit details
    Browse the repository at this point in the history

  3. Sending and checking for settings as well since some style variations… 

    … might have different settings we'd want to reinstate.

Doing a deep equality check to highlight the currently selected revision.
    @ramonjd
    ramonjd committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    9978710 View commit details
    Browse the repository at this point in the history

  4. Added a new endpoint to the global styles rest API (/revisions) 

    - Limit is 100 revisions in response
Added experimental revisions selector/action/resolver to the core-data store
Abstracted compare revisions into isGlobalStyleConfigEqual and added tests
Showing selector control in the UI if revision count is > 10
    @ramonjd
    ramonjd committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    926a2b0 View commit details
    Browse the repository at this point in the history

  5. revisions is no longer a property of the response object

    @ramonjd
    ramonjd committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    11600cf View commit details
    Browse the repository at this point in the history

  6. Update description for rest param 

    Bumped revision count that can be returned from the API to 100
    @ramonjd
    ramonjd committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    631432e View commit details
    Browse the repository at this point in the history

  7. There's no reason to use the stored userConfig at all if we're reinst… 

    …ating the full revision.

The revision should overwrite everything.
    @ramonjd
    ramonjd committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    1a13b77 View commit details
    Browse the repository at this point in the history

  8. added a test for the revisions endpoint

    @ramonjd
    ramonjd committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    bc2a83d View commit details
    Browse the repository at this point in the history

  9. Added text domain

    @ramonjd
    ramonjd committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    146464c View commit details
    Browse the repository at this point in the history

  10. Bumping minimum revision count until display to two: 

    - same behaviour as post editor
- since revisions includes the current saved post, so we need at least two in order to switch
    @ramonjd
    ramonjd committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    087e786 View commit details
    Browse the repository at this point in the history

  11. Added a very unpretty E2E test for global styles revisions. We can't … 

    …yet delete global styles revisions and, because of other tests, we can't rely on the post revisions being a certain count so we try to cater for both in the test for now.

Added aria label to buttons in the UI
    @ramonjd
    ramonjd committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    958e746 View commit details
    Browse the repository at this point in the history

  12. Formatting the comments in the E2E test. 

    Checking for the number of revision buttons in the revisions list.
    @ramonjd
    ramonjd committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    3c88909 View commit details
    Browse the repository at this point in the history

  13. Fixing up things after a rebase, mainly usage of __experimentalGetCur… 

    …rentGlobalStylesId, which has been removed in this PR.

Adding a reset button.
    @ramonjd
    ramonjd committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    5df24c5 View commit details
    Browse the repository at this point in the history

  14. Moving changes to global styles controller to 6.2 compat 

    Removing secondary button styling
    @ramonjd
    ramonjd committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    225606b View commit details
    Browse the repository at this point in the history

  15. JS LINT YO!

    @ramonjd
    ramonjd committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    5c77f1e View commit details
    Browse the repository at this point in the history

  16. Relocate js utils tests for isGlobalStyleConfigEqual

    @ramonjd
    ramonjd committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    70150bb View commit details
    Browse the repository at this point in the history

  17. Move rest route registration to compat 6.3

    @ramonjd
    ramonjd committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    10b2de0 View commit details
    Browse the repository at this point in the history

  18. update e2e tests so that they pass :D I was importing a non-existant … 

    …method
    @ramonjd
    ramonjd committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    a066ab4 View commit details
    Browse the repository at this point in the history

  19. Testing with undo/reset buttons

    @ramonjd
    ramonjd committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    be5005f View commit details
    Browse the repository at this point in the history

  20. Moving the revisions link so that it's under the drop down 

    Updating e2e tests
A sad attempt at caching the unsaved userConfig
Adding an `is_latest` prop to the rest response to indicate the latest saved revision
    @ramonjd
    ramonjd committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    eed6463 View commit details
    Browse the repository at this point in the history

  21. Yoda?

    @ramonjd
    ramonjd committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    8671471 View commit details
    Browse the repository at this point in the history

  22. Adding author display name and avatar to rest response 

    Redesigning the buttons view
Rationalizing rest API return properties
    @ramonjd
    ramonjd committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    7ee47a1 View commit details
    Browse the repository at this point in the history

  23. Update PHP tests title > date

    @ramonjd
    ramonjd committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    8640877 View commit details
    Browse the repository at this point in the history

  24. This is trash

    @ramonjd
    ramonjd committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    fc2b825 View commit details
    Browse the repository at this point in the history

  25. This is also trash.

    @ramonjd
    ramonjd committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    d16bd4d View commit details
    Browse the repository at this point in the history

  26. This is also trash.

    @ramonjd
    ramonjd committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    7287070 View commit details
    Browse the repository at this point in the history

  27. This is also trash.

    @ramonjd
    ramonjd committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    23c4a57 View commit details
    Browse the repository at this point in the history

  28. This is also trash.

    @ramonjd
    ramonjd committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    f3cfeb0 View commit details
    Browse the repository at this point in the history