-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Set image width to fit-content
to solve aspect ratio problems in Firefox. (#66217)"
#66804
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Size Change: -110 B (-0.01%) Total Size: 1.82 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for handling. LGTM
…ms in Firefox. (#66217)" (#66804) Co-authored-by: kevin940726 <[email protected]> Co-authored-by: ramonjd <[email protected]> Co-authored-by: mukeshpanchal27 <[email protected]> Co-authored-by: juanfra <[email protected]> This reverts commit 0e65adc.
I just cherry-picked this PR to the wp/6.7 branch to get it included in the next release: e503a39 |
…ms in Firefox. (WordPress#66217)" (WordPress#66804) Co-authored-by: kevin940726 <[email protected]> Co-authored-by: ramonjd <[email protected]> Co-authored-by: mukeshpanchal27 <[email protected]> Co-authored-by: juanfra <[email protected]> This reverts commit 0e65adc.
…ms in Firefox. (#66217)" (#66804) Co-authored-by: kevin940726 <[email protected]> Co-authored-by: ramonjd <[email protected]> Co-authored-by: mukeshpanchal27 <[email protected]> Co-authored-by: juanfra <[email protected]> This reverts commit 0e65adc.
Backported to Gutenberg 19.6.3 in 51e9978 |
This reverts commit 0e65adc.
What and Why?
This is an alternative to #66801.
As reported both in #66643 and #66801. The
fit-content
rule possibly introduced too many side effects that it's safer to revert it for now.This probably means we have to find another way to resolve the issue with TT5 patterns. (Reopen #66175)
How?
Revert the commit in both #66217 and #66643.
Testing Instructions
Follow the instructions in #66801. See https://core.trac.wordpress.org/ticket/62345 too.
Screenshots or screencast
N/A