-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Post Trash: Add confirmation dialog and correct trash support check #74283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
To my knowledge, and somewhat similar to the proposed solution in #74265, the If the proposal introduces a new support flag that differs from the suggestions in the original issues, it must be documented in the description. For now, I think it would be best to move the discussion back to the issue until there's a clear resolution path. |
|
Thanks for the review @Mamaduka. You are right — I was operating under the assumption that the I will pause this PR and move the discussion back to the issue thread to determine the best way to handle this check. |
|
@UmeraGhori, the problem is that the |
What:
This PR adds a confirmation dialog to the "Move to trash" button in the post editor. This ensures users do not accidentally delete posts or pages.
Technical Changes:
Based on previous feedback, I have also refactored how we check if a post type supports the 'trash' feature.
disableTrashin editor settings (which was incorrect).@wordpress/core-datastore and checkspostTypeEntity.supports.trash.storeimports to comply with linting standards.Why:
How to Test: