Improve notes notifications implementation #10488
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
|
You mentioned unit test failures and a safeguard for them - #10472 (comment). Are those no longer relative? Otherwise, we can ship this and work on the remaining tasks for 7.0. |
I don't see the failures, so I may be wrong about why I switched the location. let me do some further testing locally. |
|
Night brain realised I missed something on the earlier PR. As multisite installs often don't run the upgrade routine, Also, while doing follow up, the schema array included an empty line break at the end of the array that it would be nice to remove. wordpress-develop/src/wp-admin/includes/schema.php Lines 564 to 567 in 6e2130c |
Co-authored-by: Dovid Levine <[email protected]>
Trac Ticket MissingThis pull request is missing a link to a Trac ticket. For a contribution to be considered, there must be a corresponding ticket in Trac. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description. More information about contributing to WordPress on GitHub can be found in the Core Handbook. |
Good catch, thanks! added in 7cfb3c2
removed in 4e9f2ef |
|
Pending any other feedback I plan to commit this before RC1. |
| <br /> | ||
| <label for="wp_notes_notify"> | ||
| <input name="wp_notes_notify" type="checkbox" id="wp_notes_notify" value="1" <?php checked( '1', get_option( 'wp_notes_notify' ) ); ?> /> | ||
| <input name="wp_notes_notify" type="checkbox" id="wp_notes_notify" value="1" <?php checked( '1', get_option( 'wp_notes_notify', 1 ) ); ?> /> |
There was a problem hiding this comment.
Not a blocker: checked compare '1' string value with int 1. Do we needs to change this?
| function wp_new_comment_via_rest_notify_postauthor( $comment ) { | ||
| if ( 'note' === $comment->comment_type ) { | ||
| wp_new_comment_notify_postauthor( (int) $comment->comment_ID ); | ||
| } | ||
| } |
There was a problem hiding this comment.
For sage guard, return early if it is not comment object.
if ( ! $comment instanceof WP_Comment ) {
return;
}
5 participants
This PR address a few points of input that remained incomplete from #10472 before it was merged in order to make it into Beta 4.
Trac ticket:
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.