Skip to content

Improve notes notifications implementation #10488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: trunk
Choose a base branch
from
+16 −16
Open

Improve notes notifications implementation #10488

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
88731bf
Move wp_new_comment_via_rest_notify_postauthor -> comment.php
adamsilverstein Nov 7, 2025
60a0681
Update callback
adamsilverstein Nov 7, 2025
4e9f2ef
whitespace fix
adamsilverstein Nov 7, 2025
7cfb3c2
Ensure calls to get_option( 'wp_notes_notify’… use 1 default
adamsilverstein Nov 7, 2025
c67de29
Update src/wp-includes/comment.php
adamsilverstein Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions src/wp-includes/comment.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2458,6 +2458,19 @@ function wp_new_comment_notify_postauthor( $comment_id ) {
return wp_notify_postauthor( $comment_id );
}

/**
* Send a notification to the post author when a new note is added via the REST API.
*
* @since 6.9.0
*
* @param WP_Comment $comment The comment object.
*/
function wp_new_comment_via_rest_notify_postauthor( $comment ) {
if ( 'note' === $comment->comment_type ) {
wp_new_comment_notify_postauthor( $comment->comment_ID );
}
}

/**
* Sets the status of a comment.
*
Expand Down
2 changes: 1 addition & 1 deletion src/wp-includes/default-filters.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -522,7 +522,7 @@
// Email notifications.
add_action( 'comment_post', 'wp_new_comment_notify_moderator' );
add_action( 'comment_post', 'wp_new_comment_notify_postauthor' );
add_action( 'rest_insert_comment', array( 'WP_REST_Comments_Controller', 'wp_new_comment_via_rest_notify_postauthor' ) );
add_action( 'rest_insert_comment', 'wp_new_comment_via_rest_notify_postauthor' );
add_action( 'after_password_reset', 'wp_password_change_notification' );
add_action( 'register_new_user', 'wp_send_new_user_notifications' );
add_action( 'edit_user_created_user', 'wp_send_new_user_notifications', 10, 2 );
Expand Down
12 changes: 0 additions & 12 deletions src/wp-includes/rest-api/endpoints/class-wp-rest-comments-controller.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,18 +36,6 @@ public function __construct() {
$this->meta = new WP_REST_Comment_Meta_Fields();
}

/**
* Send a notification to the post author when a new note is added via the REST API.
*
* @since 6.9.0
*
* @param WP_Comment $comment The comment object.
*/
public static function wp_new_comment_via_rest_notify_postauthor( $comment ) {
if ( 'note' === $comment->comment_type ) {
wp_new_comment_notify_postauthor( $comment->comment_ID );
}
}
/**
* Registers the routes for comments.
*
Expand Down
Loading