Use comment status and type to set $maybe_notify default

[adamsilverstein]

Trac ticket: https://core.trac.wordpress.org/ticket/64217

---

This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props adamsilverstein.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[github-actions]

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

• The Plugin and Theme Directories cannot be accessed within Playground.
• All changes will be lost when closing a tab with a Playground instance.
• All changes will be lost when refreshing the page.
• A fresh instance is created each time the link below is clicked.
• Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
  it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

[westonruter]

Maybe this refactor into a single if/elseif/else statement is easier to reason about?

Suggested change

	$maybe_notify = $is_note ? get_option( 'wp_notes_notify' ) : get_option( 'comments_notify' );
	// By default, only notify for approved comments and notes.
	if (
	! isset( $comment->comment_approved ) ||
	( '1' !== $comment->comment_approved && ! $is_note ) ) {
	$maybe_notify = false;
	}
	// By default, only notify for approved comments and notes.
	if (
	! isset( $comment->comment_approved ) ||
	( '1' !== $comment->comment_approved && ! $is_note )
	) {
	$maybe_notify = false;
	} else if ( $is_note ) {
	$maybe_notify = get_option( 'wp_notes_notify' );
	} else {
	$maybe_notify = get_option( 'comments_notify' )
	}

[westonruter]

Aside: Will $comment->comment_approved ever be not-set or null? It's default value is '1' and it is typed as a string. Doesn't hurt, but just curious. If so, then ! isset( $comment->comment_approved ) could be removed.

[adamsilverstein]

This will change the logic slightly. If get_option( 'comments_notify' ) is true and '1' !== $comment->comment_approved and the type is a comment, the default should be false. This would make it true. I will try to make the logic clearer, maybe remove the trinary or add inline docs.