Global Footer: Switch multiple nav blocks to lists inside a nav wrapper. #455
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #402 — This switches to the global footer block to use a
nav
group block around 5 lists, instead of 5 separate nav blocks. Additionally, the label "Footer" has been added to thenav
, so it now appears as "Footer navigation" when browsing by landmark.This also had to change the way menu items were localized, removing the filter on nav-link blocks in favor of directly calling the function on appropriate links.
Props @joedolson for the report
Screenshots
To test
nav
element, individual items are listsOptionally test with a screen reader to see the single Footer navigation landmark.