Skip to content

docs: Update our Styling docs #3280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 26 commits into from
Jun 4, 2025

Conversation

mannycarrera4
Copy link
Contributor

@mannycarrera4 mannycarrera4 commented May 6, 2025

Summary

Fixes: #3275

Release Category

Documentation

Release Note

Update our Styling docs to be more prescriptive and organized.


Checklist

For the Reviewer

  • PR title is short and descriptive
  • PR summary describes the change (Fixes/Resolves linked correctly)
  • PR Release Notes describes additional information useful to call out in a release message or removed if not applicable
  • Breaking Changes provides useful information to upgrade to this code or removed if not applicable

Where Should the Reviewer Start?

Areas for Feedback? (optional)

  • Code
  • Documentation
  • Testing
  • Codemods

Testing Manually

Screenshots or GIFs (if applicable)

Thank You Gif (optional)

Copy link

cypress bot commented May 6, 2025

Workday/canvas-kit    Run #8897

Run Properties:  status check passed Passed #8897  •  git commit 5f3673e0d2 ℹ️: Merge 1bc2df91b840ab78f3aa6e9e22898a089c8b6b54 into 20b7745e5d54f5eb81ec3219fa85...
Project Workday/canvas-kit
Branch Review mc-base-component
Run status status check passed Passed #8897
Run duration 02m 56s
Commit git commit 5f3673e0d2 ℹ️: Merge 1bc2df91b840ab78f3aa6e9e22898a089c8b6b54 into 20b7745e5d54f5eb81ec3219fa85...
Committer Manuel Carrera
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 21
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 936
View all changes introduced in this branch ↗︎
UI Coverage  21.38%
  Untested elements 1524  
  Tested elements 412  
Accessibility  99.27%
  Failed rules  6 critical   5 serious   0 moderate   2 minor
  Failed elements 98  

@mannycarrera4 mannycarrera4 added the ready for review Code is ready for review label May 7, 2025
@mannycarrera4 mannycarrera4 marked this pull request as ready for review May 7, 2025 21:15
@alanbsmith alanbsmith self-assigned this May 13, 2025
@alanbsmith alanbsmith added the review in progress Code is currently under review label May 13, 2025
@mannycarrera4 mannycarrera4 changed the title feat: Add Base component that handles cs prop. docs: Update our Styling docs May 28, 2025
@jaclynjessup jaclynjessup moved this to 👀 In review in Canvas Kit Jun 2, 2025
@mannycarrera4 mannycarrera4 added this to the 13.1 milestone Jun 4, 2025
Copy link
Member

@jamesfan jamesfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few suggestions. This PR looks good to me otherwise. 👍

@jamesfan
Copy link
Member

jamesfan commented Jun 4, 2025

I changed the PR Release Category to Documentation.

@alanbsmith alanbsmith added approved Code has been reviewed and approved (ship it) automerge and removed ready for review Code is ready for review review in progress Code is currently under review labels Jun 4, 2025
@alanbsmith alanbsmith merged commit d114ca5 into Workday:prerelease/minor Jun 4, 2025
19 of 21 checks passed
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Canvas Kit Jun 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Code has been reviewed and approved (ship it) automerge
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

4 participants