-
Notifications
You must be signed in to change notification settings - Fork 232
docs: Update our Styling docs #3280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
alanbsmith
merged 26 commits into
Workday:prerelease/minor
from
mannycarrera4:mc-base-component
Jun 4, 2025
Merged
docs: Update our Styling docs #3280
alanbsmith
merged 26 commits into
Workday:prerelease/minor
from
mannycarrera4:mc-base-component
Jun 4, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Workday/canvas-kit
|
Project |
Workday/canvas-kit
|
Branch Review |
mc-base-component
|
Run status |
|
Run duration | 02m 56s |
Commit |
|
Committer | Manuel Carrera |
View all properties for this run ↗︎ |
Test results | |
---|---|
|
0
|
|
1
|
|
21
|
|
0
|
|
936
|
View all changes introduced in this branch ↗︎ |
UI Coverage
21.38%
|
|
---|---|
|
1524
|
|
412
|
Accessibility
99.27%
|
|
---|---|
|
6 critical
5 serious
0 moderate
2 minor
|
|
98
|
10 tasks
jamesfan
reviewed
May 22, 2025
jamesfan
reviewed
May 22, 2025
jamesfan
reviewed
May 22, 2025
jamesfan
reviewed
May 22, 2025
jamesfan
reviewed
May 22, 2025
jamesfan
reviewed
May 22, 2025
jamesfan
reviewed
May 22, 2025
jamesfan
reviewed
May 22, 2025
jamesfan
reviewed
May 22, 2025
jamesfan
reviewed
May 22, 2025
Co-authored-by: James Fan <[email protected]>
Base
component that handles cs
prop.…canvas-kit into mc-base-component
jaclynjessup
reviewed
Jun 2, 2025
jamesfan
approved these changes
Jun 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few suggestions. This PR looks good to me otherwise. 👍
I changed the PR Release Category to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: #3275
Release Category
Documentation
Release Note
Update our Styling docs to be more prescriptive and organized.
Checklist
ready for review
has been added to PRFor the Reviewer
Where Should the Reviewer Start?
Areas for Feedback? (optional)
Testing Manually
Screenshots or GIFs (if applicable)
Thank You Gif (optional)