Array Builder Automated Placement and Various Fixes #1309
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Butt <[email protected]>
Signed-off-by: Andrew Butt <[email protected]>
Signed-off-by: Andrew Butt <[email protected]>
Signed-off-by: Chris Lavin <[email protected]>
Signed-off-by: Andrew Butt <[email protected]>
Signed-off-by: Andrew Butt <[email protected]>
Signed-off-by: Chris Lavin <[email protected]>
Signed-off-by: Chris Lavin <[email protected]>
Signed-off-by: Chris Lavin <[email protected]>
…spine Signed-off-by: Chris Lavin <[email protected]>
Signed-off-by: Chris Lavin <[email protected]>
Signed-off-by: Chris Lavin <[email protected]>
Signed-off-by: Andrew Butt <[email protected]>
…y_builder_or_tools
Signed-off-by: Andrew Butt <[email protected]>
Signed-off-by: Chris Lavin <[email protected]>
Signed-off-by: Chris Lavin <[email protected]>
Signed-off-by: Chris Lavin <[email protected]>
Signed-off-by: Chris Lavin <[email protected]>
Signed-off-by: Chris Lavin <[email protected]>
Member
|
Yes, let's split it into two PRs. It also looks like some of the commits will need to be augmented with the sign off message. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds automated module placement to array builder and fixes various other bugs, as well as improving performance. Dependent on #1306 getting merged and then array_builder getting updated. Still needs a lot of cleanup, but opening as a draft for now, now that or-tools is getting added. I might end up splitting this into at least 2 separate PRs (one for array builder changes and one for performance explorer / inline flop tools).