[EDIFPort] Refactor getBitBlastedIndices() #1321
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chris Lavin <[email protected]>
Signed-off-by: Chris Lavin <[email protected]>
eddieh-xlnx
approved these changes
Nov 13, 2025
Collaborator
eddieh-xlnx
left a comment
eddieh-xlnx
left a comment
There was a problem hiding this comment.
I think this is an improvement?
eddieh-xlnx
reviewed
Nov 13, 2025
Co-authored-by: eddieh-xlnx <[email protected]> Signed-off-by: Chris Lavin <[email protected]>
eddieh-xlnx
reviewed
Nov 13, 2025
eddieh-xlnx
reviewed
Nov 13, 2025
Signed-off-by: Chris Lavin <[email protected]>
Co-authored-by: eddieh-xlnx <[email protected]> Signed-off-by: Chris Lavin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes two changes:
EDIFTools.getBitBlastedIndicies() name was refactored to EDIFTools.getBitBlastedIndices() and the previous spelling was marked for deprecation due to a mispelling.
The return value of this method for a single bit port was changed such that instead of returning null, it now returns an array with a single value in it
{0}. This behavior lends itself to simplifying code that traverses over ports such that it removes the need to check if it is a bussed port or single bit port.