Martien.skippresched #230
Merged
Martien.skippresched #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martien-de-jong
requested review from
abhinay-anubola,
abnikant,
andcarminati,
gbossu,
khallouh,
konstantinschwarz,
SagarMaheshwari99 and
stephenneuendorffer
as code owners
andcarminati
reviewed
Nov 5, 2024
andcarminati
reviewed
Nov 5, 2024
andcarminati
reviewed
Nov 5, 2024
added 2 commits
November 5, 2024 18:25
SKipping is based on loop metadata
martien-de-jong
force-pushed
the
martien.skippresched
branch
from
ada6613 to
c78fd16
Compare
andcarminati
reviewed
Nov 6, 2024
| // The pipeliner is usually disabled to give the postpipeliner a chance. | ||
| // The prescheduler also clutters the view of the postpipeliner, so we skip | ||
| // such blocks here. | ||
| auto Skip = [](MachineBasicBlock *Block) { |
There was a problem hiding this comment.
What do you think about a command line option to disable this?
There was a problem hiding this comment.
We discussed that this is a user-pragma driven affair so that an option is not really necessary. Om second thought I perhaps add one anyway, so that we can easily assess the overall effect of prescheduling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we want to give the postpipeliner a chance on (bigger) loops that fall outside of the normal offloading criteria, we can add a disable pragma to which the pre-pipeliner responds. In that case we also want to disable the scheduler since its actions clutter the view of the postpipeliner