Martien.exhaustiveswp #242

martien-de-jong · 2024-11-20T16:00:37Z

Set the baseline for GEMM and Conv2D_bf16
Add a provision to try multiple strategies for a single II.
Add a critical path heuristic

For best effect on QoR, the pre-pipeliner and the prescheduler should be skipped. This is forced by

#pragma clang loop pipeliner(disable)

in the source, or globally using --enable-pipeliner=0 --enable-misched=0

QOR:
I ran a like-for like comparison with the base aie-public version The CSV reporting failed, but the result json file shows significant overall improvements (up to >10%) with only a few minor sub-percent regressions

This is the tail of the diff. Trust me the regression head is tiny in comparison

llvm/test/CodeGen/AIE/aie2/schedule/postpipeliner/conv2d_bf16-1.mir

llvm/test/CodeGen/AIE/aie2/schedule/postpipeliner/conv2d_bf16.mir

llvm/lib/Target/AIE/AIEPostPipeliner.cpp

martien-de-jong · 2024-11-21T10:41:38Z

llvm/lib/Target/AIE/AIEPostPipeliner.cpp

+      N.NumPushedLatest = 0;
+      N.LastEarliestPusher = -1;
+      N.LastLatestPusher = -1;
+    }


These parameters represents the path that pushed Earliest of the failing node beyond its modulo cycle in the previous iteration. If we don't reset it, we can use it to provide look-ahead in a rerun.

llvm/lib/Target/AIE/AIEPostPipeliner.cpp

llvm/test/CodeGen/AIE/aie2/schedule/postpipeliner/conv2d_bf16-1.mir

llvm/lib/Target/AIE/AIEBaseSubtarget.cpp

llvm/test/CodeGen/AIE/aie2/schedule/status_regs/srWAW.mir

llvm/lib/Target/AIE/AIEPostPipeliner.cpp

gbossu · 2024-11-22T13:11:22Z

llvm/lib/Target/AIE/AIEPostPipeliner.cpp

-    }
-    Scoreboard[C] |= Slots;
-    MII = std::max(MII, C + 1);
+    Counts += getSlotCounts(MI, TII);


llvm/lib/Target/AIE/AIEPostPipeliner.cpp

andcarminati · 2024-11-26T08:39:55Z

llvm/test/CodeGen/AIE/aie2/schedule/postpipeliner/gemm-1.mir

+  ; CHECK-NEXT:    nop
+  ; CHECK-NEXT:    nop
+  ; CHECK-NEXT:    nop
+  ; CHECK-NEXT:    nop


The original vst.conv's can be also included, because they can be used a baseline for the epilogue merging.

llvm/test/CodeGen/AIE/aie2/schedule/postpipeliner/conv2d_bf16-1.mir

llvm/lib/Target/AIE/AIEPostPipeliner.h

gbossu · 2024-12-06T10:53:33Z

llvm/lib/Target/AIE/AIEPostPipeliner.cpp

+    if (K < NInstr) {
+      N.Earliest = N.StaticEarliest;
+      N.Latest = N.StaticLatest;
+    }


Does that imply that nodes outside of the first iteration never get an Earliest or Latest? Should we make that explicit with an optional?

They get a default 0, -1 from reset, which are sane values, not sentinels. Earliest of the second iteration is used to represent LCD latencies, but this is propagated back to the first iteration.

llvm/lib/Target/AIE/AIEPostPipeliner.cpp

llvm/lib/Target/AIE/AIEPostPipeliner.h

llvm/lib/Target/AIE/AIEPostPipeliner.cpp

gbossu

I think I'm done with the review, let me know if you want to discuss any of the comments :)

llvm/lib/Target/AIE/AIEPostPipeliner.cpp

andcarminati · 2024-12-10T13:32:33Z

llvm/test/CodeGen/AIE/aie2/schedule/postpipeliner/conv2d_bf16-1.mir

+# (c) Copyright 2024 Advanced Micro Devices, Inc. or its affiliates
+
+# RUN: llc --mtriple=aie2 -O2 --start-before=postmisched %s \
+# RUN:   --debug-only=postpipeliner-summary -o - | FileCheck %s


What is the purpose of --debug-only=postpipeliner-summary in this test?

developer convenience. update_llc_tests shows it on stderr, and the last line reports the final II.

Colors for discriminating edge types in dot graph

Include cycles neceessary for resources of ancesters/offspring in Earliest/Latest

llvm/lib/Target/AIE/AIEPostPipeliner.cpp

gbossu · 2024-12-12T11:13:11Z

llvm/lib/Target/AIE/AIEPostPipeliner.h

+  int NumPushedLatest = 0;
+
+  // Latest corrected by taking Earliest of an LCD successor into account
+  int LCDLatest = -1;


Any reason not to have a symmetric LCDEarliest for bottom-up scheduling?

No. That's an oversight.

But I guess we would not have a strategy to make use of it anyway?

Correct. Leaving it for now, but we should keep in mind that LcdLatest is asymmetric wrt TopDown now.

llvm/lib/Target/AIE/AIEPostPipeliner.cpp

We can choose the priority of a number of scheduling orderings This version only uses the previously used one.

gbossu

LGTM! I think this adds a lot of flexibility to the pipeliner and I'm sure we'll do great things with it 💪

martien-de-jong requested review from abhinay-anubola, abnikant, andcarminati, gbossu, khallouh, konstantinschwarz, SagarMaheshwari99 and stephenneuendorffer as code owners November 20, 2024 16:00

andcarminati reviewed Nov 21, 2024

View reviewed changes

llvm/test/CodeGen/AIE/aie2/schedule/postpipeliner/conv2d_bf16-1.mir Outdated Show resolved Hide resolved

andcarminati reviewed Nov 21, 2024

View reviewed changes

llvm/test/CodeGen/AIE/aie2/schedule/postpipeliner/conv2d_bf16.mir Outdated Show resolved Hide resolved

martien-de-jong commented Nov 21, 2024

View reviewed changes

llvm/lib/Target/AIE/AIEPostPipeliner.cpp Outdated Show resolved Hide resolved

martien-de-jong commented Nov 21, 2024

View reviewed changes

llvm/lib/Target/AIE/AIEPostPipeliner.cpp Show resolved Hide resolved

martien-de-jong commented Nov 21, 2024

View reviewed changes

llvm/lib/Target/AIE/AIEPostPipeliner.cpp Outdated Show resolved Hide resolved

martien-de-jong commented Nov 21, 2024

View reviewed changes

llvm/lib/Target/AIE/AIEPostPipeliner.cpp Outdated Show resolved Hide resolved

martien-de-jong commented Nov 21, 2024

View reviewed changes

llvm/lib/Target/AIE/AIEPostPipeliner.cpp Outdated Show resolved Hide resolved

gbossu reviewed Nov 22, 2024

View reviewed changes

llvm/lib/Target/AIE/AIEPostPipeliner.cpp Outdated Show resolved Hide resolved

gbossu reviewed Nov 22, 2024

View reviewed changes

llvm/lib/Target/AIE/AIEPostPipeliner.cpp Outdated Show resolved Hide resolved

gbossu reviewed Nov 22, 2024

View reviewed changes

llvm/test/CodeGen/AIE/aie2/schedule/postpipeliner/conv2d_bf16-1.mir Outdated Show resolved Hide resolved

gbossu reviewed Nov 22, 2024

View reviewed changes

llvm/lib/Target/AIE/AIEBaseSubtarget.cpp Show resolved Hide resolved

gbossu reviewed Nov 22, 2024

View reviewed changes

llvm/test/CodeGen/AIE/aie2/schedule/status_regs/srWAW.mir Outdated Show resolved Hide resolved

gbossu reviewed Nov 22, 2024

View reviewed changes

llvm/lib/Target/AIE/AIEPostPipeliner.cpp Outdated Show resolved Hide resolved

gbossu reviewed Nov 22, 2024

View reviewed changes

llvm/lib/Target/AIE/AIEPostPipeliner.cpp Show resolved Hide resolved

andcarminati reviewed Nov 26, 2024

View reviewed changes

martien-de-jong force-pushed the martien.exhaustiveswp branch from 38a992a to 650a0ee Compare November 28, 2024 15:53

andcarminati reviewed Nov 28, 2024

View reviewed changes

llvm/test/CodeGen/AIE/aie2/schedule/postpipeliner/conv2d_bf16-1.mir Outdated Show resolved Hide resolved

martien-de-jong force-pushed the martien.exhaustiveswp branch 2 times, most recently from f70cc9f to 9257966 Compare November 28, 2024 16:55

martien-de-jong commented Dec 2, 2024

View reviewed changes

llvm/lib/Target/AIE/AIEPostPipeliner.h Show resolved Hide resolved

gbossu reviewed Dec 6, 2024

View reviewed changes

llvm/lib/Target/AIE/AIEPostPipeliner.h Show resolved Hide resolved

gbossu reviewed Dec 6, 2024

View reviewed changes

llvm/lib/Target/AIE/AIEPostPipeliner.h Show resolved Hide resolved

gbossu reviewed Dec 6, 2024

View reviewed changes

llvm/lib/Target/AIE/AIEPostPipeliner.h Show resolved Hide resolved

gbossu reviewed Dec 6, 2024

View reviewed changes

llvm/lib/Target/AIE/AIEPostPipeliner.cpp Show resolved Hide resolved

gbossu reviewed Dec 6, 2024

View reviewed changes

llvm/lib/Target/AIE/AIEPostPipeliner.h Outdated Show resolved Hide resolved

gbossu reviewed Dec 6, 2024

View reviewed changes

llvm/lib/Target/AIE/AIEPostPipeliner.cpp Show resolved Hide resolved

gbossu reviewed Dec 6, 2024

View reviewed changes

martien-de-jong force-pushed the martien.exhaustiveswp branch from 5a21673 to 25f8c16 Compare December 6, 2024 15:53

gbossu reviewed Dec 9, 2024

View reviewed changes

llvm/lib/Target/AIE/AIEPostPipeliner.cpp Outdated Show resolved Hide resolved

martien-de-jong force-pushed the martien.exhaustiveswp branch from 25f8c16 to b05dcd6 Compare December 9, 2024 14:07

andcarminati reviewed Dec 10, 2024

View reviewed changes

Martien de Jong added 4 commits December 11, 2024 12:03

[AIE] Introduce PostPipelinerStrategy interface class

b8c7ab8

[AIE] maintain information about the critical path

33fca58

[AIE] dump critical path causing a RecMII failure

4e79abf

Colors for discriminating edge types in dot graph

[AIE] Refactor static computations

6273b12

Include cycles neceessary for resources of ancesters/offspring in Earliest/Latest

martien-de-jong force-pushed the martien.exhaustiveswp branch from b05dcd6 to 2a09596 Compare December 11, 2024 11:07

gbossu reviewed Dec 12, 2024

View reviewed changes

llvm/lib/Target/AIE/AIEPostPipeliner.cpp Outdated Show resolved Hide resolved

gbossu reviewed Dec 12, 2024

View reviewed changes

llvm/lib/Target/AIE/AIEPostPipeliner.cpp Show resolved Hide resolved

Martien de Jong added 6 commits December 12, 2024 16:06

[AIE] NFC Create a configurable post pipeliner strategy

9d6b69b

We can choose the priority of a number of scheduling orderings This version only uses the previously used one.

[AIE] add 'Critical' heuristic

b46bf9f

[AIE] Add config using LCDLatest & Critical

77314aa

[AIE] Add 'original order' strategy

dbd8962

[AIE] Implement bottom up scheduling with symmetric priority components

e8a798c

[AIE] Small logging changes

0eb616f

martien-de-jong force-pushed the martien.exhaustiveswp branch from 1e61802 to 0eb616f Compare December 12, 2024 15:06

gbossu approved these changes Dec 12, 2024

View reviewed changes

martien-de-jong enabled auto-merge (rebase) December 12, 2024 15:15

martien-de-jong merged commit fcfddf3 into aie-public Dec 12, 2024
8 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Martien.exhaustiveswp #242

Martien.exhaustiveswp #242

martien-de-jong commented Nov 20, 2024 •

edited

Loading

martien-de-jong Nov 21, 2024

gbossu Nov 22, 2024

andcarminati Nov 26, 2024 •

edited

Loading

gbossu Dec 6, 2024

martien-de-jong Dec 6, 2024

gbossu left a comment

andcarminati Dec 10, 2024

martien-de-jong Dec 11, 2024

gbossu Dec 12, 2024

martien-de-jong Dec 12, 2024

gbossu Dec 12, 2024

martien-de-jong Dec 12, 2024

gbossu left a comment

Martien.exhaustiveswp #242

Martien.exhaustiveswp #242

Conversation

martien-de-jong commented Nov 20, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

andcarminati Nov 26, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gbossu left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gbossu left a comment

Choose a reason for hiding this comment

martien-de-jong commented Nov 20, 2024 •

edited

Loading

andcarminati Nov 26, 2024 •

edited

Loading