Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid test conflicts between peano and chess #1617

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Avoid test conflicts between peano and chess #1617

wants to merge 3 commits into from

Conversation

stephenneuendorffer
Copy link
Collaborator

Basically there are two kinds of tests:

  1. tests which can use either compiler
  2. tests which specifically use one or the other

We need to be careful in the second case to not mix the two compilers.

fifield
fifield approved these changes Jul 22, 2024
View reviewed changes
Copy link
Collaborator

@fifield fifield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typically when I build with peano it is also the default, so it's easy to miss the need for the aiecc command line flags.

@stephenneuendorffer
Avoid test conflicts between peano and chess
9ce4d82 
Basically there are two kinds of tests:
1) tests which can use either compiler
2) tests which specifically use one or the other

We need to be careful in the second case to not mix the two compilers.
@stephenneuendorffer
more..
845fd6e
@stephenneuendorffer
[AIE1] Add some missing stream wrappers
b749b3c 
There was a test for this, but it wasn't getting run.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fifield fifield fifield approved these changes

@AndraBisca AndraBisca Awaiting requested review from AndraBisca AndraBisca is a code owner

@makslevental makslevental Awaiting requested review from makslevental

@jgmelber jgmelber Awaiting requested review from jgmelber jgmelber is a code owner

@jackl-xilinx jackl-xilinx Awaiting requested review from jackl-xilinx jackl-xilinx is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stephenneuendorffer @fifield