Fixing dynamic objectFifo

[pvasireddy-amd]

Issue #1884

[github-actions]

Coverage Report

Created: 2024-12-05 23:21

Click here for information about interpreting this report.

Filename	Function Coverage	Line Coverage	Region Coverage	Branch Coverage
home/runner/work/mlir-aie/mlir-aie/lib/Dialect/AIE/Transforms/AIEObjectFifoStatefulTransform.cpp	100.00%	93.49%	90.11%	84.84%
Totals	100.00%	93.49%	90.11%	84.84%

Generated by llvm-cov -- llvm version 14.0.0

[pvasireddy-amd]

Note: The sliding_window_conditional example is the only one that fails now, but this issue appears unrelated to dynamic objectFifos. The example defines 3 input objectFifos, but only 2 buffers are created when lowered using the --aie-objectFifo-stateful-transform pass. This results in runtime_error. Currently investigating the problem with objectFifo inferring depth in if-else case.

[pvasireddy-amd]

Since the problem is unrelated to the dynamic objectFifos, I have pushed a working MLIR version of the sliding_window_conditional example into test/npu-xrt/dynamic_object_fifo/sliding_window_conditional. A separate PR will follow with the necessary fixes to enable running the Python version of this example.

[AndraBisca]

Thank you for the fix!
Regarding the sliding_window_conditional example, it appears that the if-statement does not lower from IRON to MLIR as there is no wrapper similar to the for_ loop statement. As we plan to add this change in a subsequent PR I am happy to merge this fix in already.

[hunhoffe]

For the record, mlir-python-extras should contain some wrappers for if statements e.g., here: https://github.com/makslevental/mlir-python-extras/blob/b19f9b4246a0e092a2f30eaa6dde8584adb64bc5/mlir/extras/dialects/ext/scf.py#L363

I have not attempted to use them in IRON, but wanted to mention them for whoever goes down that path later on!