Remove explicit AIENGINE and AIEARCH defines from compiler driver #1983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgmelber
requested review from
stephenneuendorffer,
AndraBisca,
denolf and
fifield
as code owners
stephenneuendorffer
approved these changes
Dec 17, 2024
We currently testing with vitis 2023.2 and with the vitis essentials from ryzen ai sw 1.3 (out of date ea version). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AIENGINE and AIEARCH do not need to be explicitly defined by the compiler, the compiler flags for the architecture (ie.
--aiearch aie_ml) handle the architecture selection expression.This is a step towards using the general open source aie_api rather than my fork that comments out the include for adf headers.
This PR builds off of #1982: diff