Skip to content

GUI: standardize action button labels by changing "New..." to "Add..." #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

GUI: standardize action button labels by changing "New..." to "Add..." #49

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion addon/globalPlugins/webAccess/gui/actions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ def makeSettings(self, settingsSizer):

col += 1
# Translators: The label for a button in the Rule Editor dialog
item = self.addButton = wx.Button(self, label=_("&New..."))
item = self.addButton = wx.Button(self, label=_("&Add..."))
item.Bind(wx.EVT_BUTTON, self.onAddGesture)
items.append(item)
gbSizer.Add(item, pos=(row, col), flag=wx.EXPAND)
Expand Down
4 changes: 2 additions & 2 deletions addon/globalPlugins/webAccess/gui/criteriaEditor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -887,7 +887,7 @@ def makeSettings(self, settingsSizer):
self.listLabel.Label = _("Properties specific to this criteria set")
listCtrl = self.listCtrl
# Translators: A hint stating a list is empty and how to populate it on the Criteria Editor dialog
listCtrl.descriptionIfEmpty = _("None. Press alt+n to override a property.")
listCtrl.descriptionIfEmpty = _("None. Press Alt+A to override a property.")
# Translators: A column header in the Criteria Editor dialog
self.listCtrl.InsertColumn(2, _("Rule value"))

Expand All @@ -897,7 +897,7 @@ def makeSettings(self, settingsSizer):

col += 1
# Translators: The label for a button on the Criteria Editor dialog
item = self.addPropBtn = wx.Button(self, label=_("&New")) #FIXME, size=(-1, 30))
item = self.addPropBtn = wx.Button(self, label=_("&Add")) #FIXME, size=(-1, 30))
item.Enable(False)
item.Bind(wx.EVT_BUTTON, self.onAddPropBtn)
gbSizer.Add(item, pos=(row, col))
Expand Down
14 changes: 7 additions & 7 deletions addon/globalPlugins/webAccess/gui/rule/editor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,7 +355,7 @@ def makeSettings(self, settingsSizer):

row = 0
# Translators: Label for a control in the Rule Editor
item = wx.StaticText(self, label=_("&Alternatives"))
item = wx.StaticText(self, label=_("A&lternatives"))
gbSizer.Add(item, pos=(row, 0))

row += 1
Expand Down Expand Up @@ -398,8 +398,8 @@ def makeSettings(self, settingsSizer):

col += 1
# Translators: The label for a button on the Rule Editor dialog
item = self.newButton = wx.Button(self, label=_("&New..."))
item.Bind(wx.EVT_BUTTON, self.onNewCriteria)
item = self.newButton = wx.Button(self, label=_("&Add..."))
item.Bind(wx.EVT_BUTTON, self.onAddCriteria)
gbSizer.Add(item, pos=(row, col))

row += 1
Expand Down Expand Up @@ -457,7 +457,7 @@ def onCriteriaChange(self, change: Change, index: int):
self.refreshParent(self.categoryParams.treeNode)

@guarded
def onNewCriteria(self, evt):
def onAddCriteria(self, evt):
context = self.context
prm = self.categoryParams
context["data"]["criteria"] = OrderedDict({
Expand Down Expand Up @@ -643,8 +643,8 @@ def makeSettings(self, settingsSizer):
# Keep natural visual ordering but set last in tab order
row = summaryStartRow
# Translators: New criteria button label
item = self.newButton = wx.Button(self, label=_("&New..."))
item.Bind(wx.EVT_BUTTON, self.onNewCriteria)
item = self.newButton = wx.Button(self, label=_("&Add..."))
item.Bind(wx.EVT_BUTTON, self.onAddCriteria)
gbSizer.Add(item, pos=(row, col))

row += 1
Expand Down Expand Up @@ -736,7 +736,7 @@ def makeSettings(self, sizer):
# Keep natural visual ordering but set last in tab order
col = 0
# Translators: The label for a button on the Rule Editor dialog
item = wx.Button(self, label=_("&New..."))
item = wx.Button(self, label=_("&Add..."))
item.Bind(wx.EVT_BUTTON, self.onAddGesture)
gbSizer.Add(item, pos=(row, col))

Expand Down