Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Use pkg for external deps #40

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

vesavlad
Copy link

The idea behind this PR is to use PKG tool https://github.com/motis-project/pkg in order to manage external dependencies with keeping a lightweight project structure.

This is a WIP since it relies on some changes that have to happen on the linked (from now on) submodules.

@vesavlad
Copy link
Author

@patrickbr what do you think about this? the idea is to make this a step into merging so more changes related to PBF processing using a osmium version that does not need BOOST as a dependency to work

But as you can see some changes need to happen to the submodules in order for them to be used a proper c++ cmake libraries

@patrickbr
Copy link
Member

Thanks, interesting idea. Glancing over the example in the pkg README, I don't quite understand the difference to vanilla git submodules. The example file looks very much like a .gitmodules file. Could you explain in a sentence or two what the difference is?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants