Conversation
|
📚 Branch Preview🔍 Visual Regression Test ResultsWhen a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:
Deployed to Azure Blob Storage: If the changes are expected, update the |
Tachometer resultsCurrently, no packages are changed by this PR... |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| "@spectrum-web-components/underlay": "1.7.0", | ||
| "focus-trap": "^7.6.4" | ||
| }, | ||
| "types": "./src/index.d.ts", |
There was a problem hiding this comment.
Expected object keys to be in specified order. 'types' should be before 'dependencies'.
reviewdog suggestion error
GitHub comment range and suggestion line range must be same. L177-L177 v.s. L153-L177
| return fragment.children[0] as HTMLElement; | ||
| }; | ||
|
|
||
| const openModalOverlay = async (event: Event) => { |
There was a problem hiding this comment.
Missing return type on function.
| container?.insertAdjacentElement('afterend', overlay); | ||
| }; | ||
|
|
||
| const openAutoOverlay = async (event: Event) => { |
There was a problem hiding this comment.
Missing return type on function.
| if (this.type === 'modal' || this.type === 'page') { | ||
| if ( | ||
| (this.type === 'modal' || this.type === 'page') && | ||
| this.receivesFocus !== 'false' |
There was a problem hiding this comment.
Move this condition to the initialFocus instead, because we want to have focus trap anyway
| case 'modal': | ||
| return 'auto'; | ||
| case 'page': | ||
| return 'manual'; |
There was a problem hiding this comment.
this changed, but github diff doesn't show it very well
| this.stack.forEach((overlayEl) => { | ||
| const inPath = path.find((el) => el === overlayEl); | ||
|
|
||
| // Check if the trigger element is inside this overlay |
There was a problem hiding this comment.
dubious if needed
| return 'auto'; | ||
| case 'page': | ||
| return 'manual'; | ||
| case 'hint': |
There was a problem hiding this comment.
I changed hint to be hint, because why not?
There was a problem hiding this comment.
maybe we can't do this because previously multiple hints could be open by using hint it closes the previous open hint
1 participant
Description
Motivation and context
Related issue(s)
Screenshots (if appropriate)
Author's checklist
Reviewer's checklist
patch,minor, ormajorfeaturesManual review test cases
Descriptive Test Statement
Descriptive Test Statement
Device review