[CLIENT-3833] CI/CD: Replace building a custom server image with a shell script that customizes aerospike.conf and provisions the server at runtime

.github/actions/run-ee-server/action.yml

@@ -28,10 +28,14 @@ inputs:
     required: false
     description: 'docker-host, separate-docker-container, "remote-connection" via DOCKER_HOST'
     default: 'docker-host'
-  docker-run-extra-flags:
+  env-vars:
     required: false
     description: Used to disable server features
-    default: ''
+    default: 'STRONG_CONSISTENCY=1 SECURITY=1 MUTUAL_TLS=1'
+outputs:
+  container-name:
+    description: 'Server container name'
+    value: ${{ steps.get-container-name.outputs.container-name }}
 
 runs:
   using: "composite"
@@ -49,58 +53,23 @@ runs:
   - run: echo IMAGE_FULL_NAME=${{ inputs.registry-name }}/${{ inputs.image-name }}:${{ inputs.server-tag }} >> $GITHUB_ENV
     shell: bash
 
-  - run: echo NEW_IMAGE_FULL_NAME=${{ env.IMAGE_FULL_NAME }}-python-client-testing >> $GITHUB_ENV
-    shell: bash
-
-  # QE images are not multi-platform and only support a single platform.
-  - name: Allow building images from different platforms other than the native one
-    uses: docker/setup-qemu-action@v3
-
-  # macOS Github runners and Windows self-hosted runners don't have buildx installed by default
-  - if: ${{ runner.os == 'Windows' || runner.os == 'macOS' }}
-    uses: docker/setup-buildx-action@v3
-
   - run: echo CA_CERT_FILE_NAME="ca.cer" >> $GITHUB_ENV
     shell: bash
 
   - run: echo TLS_PORT="4333" >> $GITHUB_ENV
     shell: bash
 
-  - name: Build Aerospike server Docker image for testing
-    # We enable TLS standard authentication to verify that the OpenSSL library bundled with the wheel works
-    # You can manually verify this by enabling debug logging in the client and checking that the server certificate was verified
-    uses: docker/build-push-action@v6
-    with:
-      # Don't want to use default Git context or else it will clone the whole Python client repo again
-      context: .github/workflows/docker-build-context
-      build-args: |
-        SERVER_IMAGE=${{ env.IMAGE_FULL_NAME }}
-        TLS_PORT=${{ env.TLS_PORT }}
-      tags: ${{ env.NEW_IMAGE_FULL_NAME }}
-      # setup-buildx-action configures Docker to use the docker-container build driver
-      # This driver doesn't publish an image locally by default
-      # so we have to manually enable it
-      load: true
-
-  - run: echo SERVER_CONTAINER_NAME="aerospike" >> $GITHUB_ENV
-    shell: bash
-
-  # Confirmed via logs that input string will not be quoted in bash
-  - run: docker run -d ${{ inputs.docker-run-extra-flags }} --name ${{ env.SERVER_CONTAINER_NAME }} -p 3000:3000 -p ${{ env.TLS_PORT }}:${{ env.TLS_PORT }} ${{ env.NEW_IMAGE_FULL_NAME }}
-    shell: bash
-
   - name: 'macOS: install timeout command'
     if: ${{ runner.os == 'macOS' }}
     run: brew install coreutils
     shell: bash
 
-  - name: Wait for container to be healthy
-    run: |
-      timeout 30s bash -c 'until [[ "$(docker inspect -f {{.State.Health.Status}} ${{ env.SERVER_CONTAINER_NAME }})" == "healthy" ]]; do sleep 0.1; done'
+  - run: ${{ inputs.env-vars }} bash ./run-ee-server.bash
+    working-directory: .github/workflows/docker-setup
     shell: bash
 
-  # For debugging
-  - run: docker logs ${{ env.SERVER_CONTAINER_NAME }}
+  - id: get-container-name
+    run: echo container-name=aerospike >> $GITHUB_OUTPUT
     shell: bash
 
   # Configure tests
@@ -129,9 +98,9 @@ runs:
       crudini --existing=param --set config.conf enterprise-edition password ${{ env.SUPERUSER_NAME_AND_PASSWORD }}
       crudini --set config.conf tls enable true
       # Cannot use abs path because config.conf is copied into Docker container during cibuildwheel tests
-      crudini --set config.conf tls cafile ../.github/workflows/docker-build-context/${{ env.CA_CERT_FILE_NAME }}
-      crudini --set config.conf tls keyfile ../.github/workflows/docker-build-context/client.pem
-      crudini --set config.conf tls certfile ../.github/workflows/docker-build-context/client.cer
+      crudini --set config.conf tls cafile ../.github/workflows/docker-setup/${{ env.CA_CERT_FILE_NAME }}
+      crudini --set config.conf tls keyfile ../.github/workflows/docker-setup/client.pem
+      crudini --set config.conf tls certfile ../.github/workflows/docker-setup/client.cer
 
     working-directory: test
     shell: bash
@@ -152,7 +121,7 @@ runs:
 
   - name: Set IP address to Docker container for the server
     if: ${{ inputs.where-is-client-connecting-from == 'separate-docker-container' }}
-    run: echo SERVER_IP=$(docker container inspect -f '{{ .NetworkSettings.IPAddress }}' ${{ env.SERVER_CONTAINER_NAME }}) >> $GITHUB_ENV
+    run: echo SERVER_IP=$(docker container inspect -f '{{ .NetworkSettings.IPAddress }}' ${{ steps.get-container-name.outputs.container-name }}) >> $GITHUB_ENV
     shell: bash
 
   - name: Invalid input
@@ -161,7 +130,9 @@ runs:
     shell: bash
 
   - name: Get cluster name
-    run: echo CLUSTER_NAME=$(docker exec ${{ env.SERVER_CONTAINER_NAME }} asinfo -v "get-config:context=service" -l | grep -i cluster-name | cut -d = -f 2) >> $GITHUB_ENV
+    # Here we just assume that security is enabled. Whenever the dev tests are run with run-ee-server.yml, security is enabled anyways.
+    # TODO: but this needs to be fixed eventually for other clients that disable security for their tests.
+    run: echo CLUSTER_NAME=$(docker run --rm --network host aerospike/aerospike-tools asinfo -U admin -P admin -v "get-config:context=service" -l | grep -i cluster-name | cut -d = -f 2) >> $GITHUB_ENV
     shell: bash
 
   - name: Set EE server's IP address

.github/actions/wait-for-ce-server-to-start/action.yml

@@ -12,15 +12,11 @@ runs:
   - run: echo WAIT_SCRIPT_FILE_NAME=wait-for-as-server-to-start.bash >> $GITHUB_ENV
     shell: bash
 
-  - name: Copy wait script in server Docker container
-    run: docker cp $WAIT_SCRIPT_FILE_NAME ${{ inputs.container-name }}:/
-    working-directory: .github/workflows/docker-build-context
-    shell: bash
-
   # There is no healthcheck by default in the server CE Docker image.
   # We can just reuse our wait script. because the CE server should be ready after it finishes.
   - name: Wait for EE server to start
     # Composite actions doesn't support step-level timeout-minutes, so we use timeout command.
     # Call bash shell explicitly since timeout uses "sh" shell by default, for some reason
-    run: docker exec ${{ inputs.container-name }} timeout 30s bash /$WAIT_SCRIPT_FILE_NAME
+    run: timeout 30s bash $WAIT_SCRIPT_FILE_NAME
     shell: bash
+    working-directory: .github/workflows/docker-setup

.github/workflows/build-wheels.yml

@@ -335,8 +335,6 @@ jobs:
     - run: |
         # Checks that server started up properly
         docker logs aerospike
-        # Prints the actual logs from asd
-        docker exec aerospike cat /var/log/aerospike/aerospike.log
       if: ${{ always() && env.RUN_INTEGRATION_TESTS_IN_CIBW == 'true' }}
       shell: bash