fix: RTL toolbar missing #365
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tengweiherr is attempting to deploy a commit to the Million Team on Vercel. A member of the Team first needs to authorize it. |
commit: |
tengweiherr
commented
Apr 13, 2025
| className={cn( | ||
| 'react-scan-inspector-overlay', | ||
| 'fixed inset-0 w-screen h-screen', | ||
| 'fixed top-0 left-0 w-screen h-screen', |
Contributor
Author
There was a problem hiding this comment.
This is to fix the following canvas positioning issue in RTL.
issue-1.mov
Notice that the initial render's outlines flushing is fine because of top-0 left-0 in here
Collaborator
|
Hoping to review this soon! |
Contributor
Author
|
@RobPruzan Bump😄 |
|
@RobPruzan Another kind bump 🙏 |
Contributor
Author
|
@RobPruzan another kind bump 😇 |
Collaborator
will be available in a few days! Finishing up finals right now, so super busy |
Contributor
Author
|
@RobPruzan no worries, good luck with your finals! |
Collaborator
|
Looks great! Thanks for the PR :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #358
Changes
documentElementExamples
demo-1-1.mp4