-
Notifications
You must be signed in to change notification settings - Fork 340
fix: RTL toolbar missing #365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
RobPruzan
merged 9 commits into
aidenybai:main
from
tengweiherr:fix/rtl-toolbar-missing
May 13, 2025
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
28cd191
fix toolbar missing in RTL
tengweiherr 86a4667
change inset-0 to top-0 left-0
tengweiherr a2e7520
handle RTL bounds
tengweiherr 2cd93c4
clean up
tengweiherr fe25271
add comments
tengweiherr 11ccba0
add comments
tengweiherr d1e038c
fix: rtl toolbar missing
tengweiherr 758ffef
clean up
tengweiherr 24477b0
change inset-0 to top-0 left-0
tengweiherr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is to fix the following canvas positioning issue in RTL.
issue-1.mov
Notice that the initial render's outlines flushing is fine because of
top-0 left-0in here